-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unwanted languages downloaded #87
Comments
Extras (eg manuals) don't have languages specificied so they always get
included if extras are allowed. Some of these could get tagged
heuristically but extras don't have well defined naming conventions.
And GOG for some reason doesn't tag language pack patches with their
language, so they just look like patches. I could probably tag nearly all
of these heuristically.
Given that:
I would have to check Master of Magic Classic (sometimes languages/OSes
that aren't officially supported get included as extras, so it's probably
correct behaviour).
The others are are as expected.
…On Sat, 11 Feb 2023, 05:59 PoloDePoli, ***@***.***> wrote:
On my set-up (and ever since) I have updated the manifest through python
gogrepoc update -os windows -lang en.
When downloading the games via python gogrepoc download, other languages
beyond english are downloaded
E.g.
1. Master of Magic Classic: french and german were also downloaded
2. The Witcher 3 Wild Hunt Game:
- br, de, fr, jp, pl, ru language packs;
- bonus packs in french, german, italian, polish, russian & spanish
3. Project Eden: french manual
4. Syndicate: french manual and reference card
5. Forgotten Realms Unlimited Adventures: german manual and reference
card
6. The Witcher: italian, polish & german manual and game guides
7.
- other like the above examples
Is this the expected behaviour?
—
Reply to this email directly, view it on GitHub
<#87>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKZ336DMCXNDALGPMSDNRDWW2M2NANCNFSM6AAAAAAUYFU72Y>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Thanks - for old games the extra languages are not too bad, however for newer ones (e.g. The Witcher) it can become quite a significant size (~30gb) of unwanted material |
Yeah, it's not ideal. You should be able to use the -skip flag I think it
is to specify filenames to skip, I *think* it allows wild cards (*?).
…On Sat, 11 Feb 2023, 06:22 PoloDePoli, ***@***.***> wrote:
Thanks - for old games the extra languages are not too bad, however for
newer ones (e.g. The Witcher) it can become quite a significant size
(~30gb) of unwanted material
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKZ33YQSCVCUXYR2TBFEF3WW2PQPANCNFSM6AAAAAAUYFU72Y>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
So I would use And would that be for the update command or for the download command? |
It's not that sophisticated unfortunately. Wildcards match all matches and
can't be constrained like that unfortunately. Though english extras usually
skip language tagging in the name at all so you rarely have to worry about
false positives there.
…On Sat, 11 Feb 2023, 06:32 PoloDePoli, ***@***.***> wrote:
So I would use -skip bonus_pack_*.zip *french* *german* *italian* *polish*
*russian* building an extensive list of all the files I do not want?
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABKZ334JYQTEQRG63CN266TWW2QURANCNFSM6AAAAAAUYFU72Y>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I did just have a look at Master of Magic Classic, and the behaviour with French/German are "correct" in that they are indeed supplied as unsupported extras, so gogrepoc treats them as languageless extras . |
On my set-up (and ever since) I have updated the manifest through
python gogrepoc update -os windows -lang en
.When downloading the games via
python gogrepoc download
, other languages beyond english are downloadedE.g.
Is this the expected behaviour?
The text was updated successfully, but these errors were encountered: