From 9220e53652396f9eb1c3664cccf03cc2efd57442 Mon Sep 17 00:00:00 2001 From: Vladyslav Budichenko Date: Mon, 16 Sep 2024 12:08:21 -0400 Subject: [PATCH] feat: add comment --- .env | 2 +- .github/workflows/ci-e2e-no-metrics-tests.yml | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.env b/.env index d047202..d7f08e3 100644 --- a/.env +++ b/.env @@ -129,7 +129,7 @@ METRIC_PRUNING_MAX_REQUEST_METRICS_HISTORY_DAYS=45 # If we use metric database. If set to false, # all metric collection and connection to the DB would be disabled # and the service would run without any metrics. -METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED:-true} +METRIC_DATABASE_ENABLED=${METRIC_DATABASE_ENABLED} # CACHE_ENABLED specifies if cache should be enabled. By default cache is disabled. CACHE_ENABLED=true # REDIS_ENDPOINT_URL is an url of redis diff --git a/.github/workflows/ci-e2e-no-metrics-tests.yml b/.github/workflows/ci-e2e-no-metrics-tests.yml index a06bc53..76684db 100644 --- a/.github/workflows/ci-e2e-no-metrics-tests.yml +++ b/.github/workflows/ci-e2e-no-metrics-tests.yml @@ -17,7 +17,9 @@ jobs: - name: pull pre-built images run: sudo docker compose -f ci.docker-compose.yml pull - name: build and start proxy service and it's dependencies - run: METRIC_DATABASE_ENABLED=false sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis + # We need to provide additional env file to override the METRIC_DATABASE_ENABLED variable, not via env variable. + # Mentioned here: https://github.com/docker/compose/issues/9737 + run: sudo docker compose -f ci.docker-compose.yml up -d --build proxy redis env: METRIC_DATABASE_ENABLED: "false" - name: wait for proxy service to be running