-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark mode problems #99
Comments
N.b. the desired behavior would be (1) comes up in light mode with the switch in the right place (2) Navbar text is in the same color no matter the light/dark mode switch, since it's on the same dark red background (3) dark/light mode switch is persistent across switching to other pages in the docs site. |
Well, actually for 1 is should remember your last setting, which it should already do, on first visit or on any visit when local store isn't available, it should detect your system preferences and give you that version. |
KhronosGroup/antora-ui-khronos#17 <-- that should fix everything requested. |
Building out of CI with the latest UI package, I initially see the light mode theme, but the selector in the upper right is on dark mode. The Antora navbar contains black text on a dark red background, almost unreadable:
Switching the selector to light mode, there is no change in the UI or navbar aside from the switch position:
Switching back to dark mode, it comes up as presumably intended, with white text in the navbar on the dark red background
Then, switching to another page in the site (via the left navigation menu, say) returns to the same state of using the light mode theme with the selector on dark mode, no matter whether in dark or light mode in the page you just left.
The text was updated successfully, but these errors were encountered: