Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode problems #99

Open
oddhack opened this issue Dec 11, 2024 · 3 comments
Open

Dark mode problems #99

oddhack opened this issue Dec 11, 2024 · 3 comments
Assignees

Comments

@oddhack
Copy link
Collaborator

oddhack commented Dec 11, 2024

Building out of CI with the latest UI package, I initially see the light mode theme, but the selector in the upper right is on dark mode. The Antora navbar contains black text on a dark red background, almost unreadable:

docs1

Switching the selector to light mode, there is no change in the UI or navbar aside from the switch position:

docs2

Switching back to dark mode, it comes up as presumably intended, with white text in the navbar on the dark red background

docs3

Then, switching to another page in the site (via the left navigation menu, say) returns to the same state of using the light mode theme with the selector on dark mode, no matter whether in dark or light mode in the page you just left.

@oddhack
Copy link
Collaborator Author

oddhack commented Dec 11, 2024

N.b. the desired behavior would be (1) comes up in light mode with the switch in the right place (2) Navbar text is in the same color no matter the light/dark mode switch, since it's on the same dark red background (3) dark/light mode switch is persistent across switching to other pages in the docs site.

@oddhack oddhack closed this as completed Dec 11, 2024
@oddhack oddhack reopened this Dec 11, 2024
@gpx1000
Copy link
Collaborator

gpx1000 commented Dec 11, 2024

Well, actually for 1 is should remember your last setting, which it should already do, on first visit or on any visit when local store isn't available, it should detect your system preferences and give you that version.
2 it's not the same red color background on the navbar. darkmode is darker.
3 the mode should presist across pages now. I'll work on a new version if I have time next week. Number 1 is a fairly easy request (just set those text colors to white everywhere. The other two have to deal with local store which can be tricky.

@gpx1000
Copy link
Collaborator

gpx1000 commented Dec 11, 2024

KhronosGroup/antora-ui-khronos#17 <-- that should fix everything requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants