Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add custom resolver feature #1067

Closed
8 tasks done
CalvinWilkinson opened this issue Jan 6, 2025 · 0 comments · Fixed by #1068
Closed
8 tasks done

🚧Add custom resolver feature #1067

CalvinWilkinson opened this issue Jan 6, 2025 · 0 comments · Fixed by #1068
Assignees
Labels
area:content Changes related to loading and managing content ✨new-feature New feature that does not exist preview Done while in preview

Comments

@CalvinWilkinson
Copy link
Member

CalvinWilkinson commented Jan 6, 2025

Complete The Item Below

  • I have updated the title without removing the 🚧 emoji.

Description

Add overloads for four methods in the ContentLoaderFactory class. These overloads will take in a parameter of type IContentPathResolver.

This will then be injected into the loader type in each factory method. This will give users the ability to create their path resolvers for loaders. This means a user cannot be forced to use the default content paths built into Velaptor and can choose where they would like content to be located.

This overall gives users more flexibility in how and where they load their content.

Add overloads for the following methods:

  1. CreateTextureLoader
  2. CreateAtlasLoader
  3. CreateAudioLoader
  4. CreateFontLoader

Acceptance Criteria

The items to complete to satisfy the Definition of Done.

Preview Give feedback

ToDo Items

The items to complete to satisfy the Definition of Done.

Preview Give feedback

Issue Dependencies

No response

Related Work

No response

Additional Information:

Unit Tests

Reasons for local unit test execution:

  • Unit tests might pass locally but not in the CI environment during the status check process or vice-versa.
  • Tests might pass on the developer's machine but not necessarily on the code reviewer's machine.
  • If you notice that the test status check has passed but the test failed locally, please notify a project maintainer!

💡Warning💡
If the unit tests pass remotely and are not executed locally, this means we could be letting a bug slip into production.
Though bugs will always exist in some capacity, we should all do our part to help prevent them from happening.

Change Type Labels

Change Type Label
Bug Fixes 🐛bug
Breaking Changes 🧨breaking-changes
New Feature ✨new-feature
CICD Changes ♻️cicd
Config Changes ⚙️config
Performance Improvements 🏎️performance
Code Doc Changes 🗒️documentation/code
Product Doc Changes 📝documentation/product

Priority Type Labels

Priority Type Label
Low Priority low priority
Medium Priority medium priority
High Priority high priority

Code of Conduct

  • I agree to follow this project's Code of Conduct.
@CalvinWilkinson CalvinWilkinson added area:content Changes related to loading and managing content preview Done while in preview ✨new-feature New feature that does not exist labels Jan 6, 2025
@CalvinWilkinson CalvinWilkinson added this to the v1.0.0-preview.40 milestone Jan 6, 2025
@CalvinWilkinson CalvinWilkinson self-assigned this Jan 6, 2025
@github-project-automation github-project-automation bot moved this to ⚪Not Set in KD-Team Jan 6, 2025
@CalvinWilkinson CalvinWilkinson moved this from ⚪Not Set to 🏗️In Development in KD-Team Jan 6, 2025
CalvinWilkinson added a commit that referenced this issue Jan 6, 2025
CalvinWilkinson added a commit that referenced this issue Jan 7, 2025
* Start work for issue #1067

* feat: add overload method for loading textures to ContentLoaderFactory

* feat: add overload method for loading atlas to ContentLoaderFactory

* feat: add overload method for loading audio to ContentLoaderFactory

* chore: remove unnecessary dependency injection

* feat: add overload method for loading fonts to ContentLoaderFactory
@github-project-automation github-project-automation bot moved this from 🏗️In Development to ✅Done in KD-Team Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:content Changes related to loading and managing content ✨new-feature New feature that does not exist preview Done while in preview
Projects
Status: ✅Done
Development

Successfully merging a pull request may close this issue.

1 participant