From afd62259597180ea48c89618c9bf9d31b6bd93fc Mon Sep 17 00:00:00 2001 From: Travis Northcutt Date: Fri, 1 Feb 2019 15:29:44 -0700 Subject: [PATCH] Clarify that an API key and API secret are both needed (#171) Without an API secret, lots of plugin functionality would silently fail. Bad UX! This makes it clear that both are needed. Closes #146 --- admin/section/class-convertkit-settings-general.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/admin/section/class-convertkit-settings-general.php b/admin/section/class-convertkit-settings-general.php index f89064dbf..1faa5e515 100644 --- a/admin/section/class-convertkit-settings-general.php +++ b/admin/section/class-convertkit-settings-general.php @@ -137,7 +137,8 @@ public function api_key_callback() { isset( $this->options['api_key'] ) ? esc_attr( $this->options['api_key'] ) : '' ); - $html .= '

' . __( 'Get your ConvertKit API Key', 'convertkit' ) . '

'; + $html .= '

' . __( 'Get your ConvertKit API Key.', 'convertkit' ) . ''; + $html .= ' ' . __( 'Required for proper plugin function.', 'convertkit' ) . '

'; $has_api = isset( $this->options['api_key'] ) ? esc_attr( $this->options['api_key'] ) : false; @@ -159,7 +160,7 @@ public function api_secret_callback() { $html .= '

'; $html .= __( 'Get your ConvertKit API Secret.', 'convertkit' ) . ''; - $html .= ' ' . __( 'This setting is required to unsubscribe subscribers.', 'convertkit' ) . '

'; + $html .= ' ' . __( 'Required for proper plugin function.', 'convertkit' ) . '

'; echo $html; // WPCS: XSS ok. }