Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Improve documentation by removing broken links #811

Closed
thr3-arendt opened this issue Oct 4, 2024 · 1 comment · Fixed by #812
Closed

Suggestion: Improve documentation by removing broken links #811

thr3-arendt opened this issue Oct 4, 2024 · 1 comment · Fixed by #812

Comments

@thr3-arendt
Copy link
Contributor

Q A
Bundle version 6.5.0
Symfony version x.y.z
PHP version x.y.z

Support Question

I was looking for the current Changelog / Upgrade files (coming from an older version) in the current README. The links are in the README under the "Latest updates" section, and are both files don't exist in the repository anymore, leading to a broken link. I believe they were removed intentionally: #802 and 9020966. I wonder if maybe you want to update the README, perhaps pointing to the https://github.com/KnpLabs/KnpPaginatorBundle/releases section?

@garak
Copy link
Collaborator

garak commented Oct 4, 2024

You're right, my bad! I didn't notice those links .
Definitely we need to fix them, do you mind to propose a pull request?

thr3-arendt added a commit to thr3-arendt/KnpPaginatorBundle that referenced this issue Oct 4, 2024
@garak garak closed this as completed in #812 Oct 5, 2024
garak pushed a commit that referenced this issue Oct 5, 2024
* Fixes #811 by replacing broken links with working link to releases page
* Removes link to nonexistent documentation for extending
* Uses https link for composer, packagist.org.
* Formats and aligns some comments for nicer readability
* Fixes #798 by removing dead link (and formerly badge) to http://knpbundles.com/KnpLabs/KnpPaginatorBundle
* Releases trailing commas added in 9cb2f2e out of habit, because it is likely just a personal style preference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants