Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proxy - check sufficient token src amount before calling transfer #1057

Open
ilanDoron opened this issue Aug 6, 2020 · 0 comments
Open

proxy - check sufficient token src amount before calling transfer #1057

ilanDoron opened this issue Aug 6, 2020 · 0 comments
Labels
enhancement kyberProxy contract

Comments

@ilanDoron
Copy link
Contributor

Its a valid scenarios that use doesn't have sufficient source amount.
happens when a few trades from same account are called and are being mined.

problem: with current code. transferFrom will fail and consume all gas.
solution: check srcAmount before calling transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement kyberProxy contract
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ilanDoron