Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad function call in conversion rate (pricing) #291

Open
ilanDoron opened this issue Aug 28, 2018 · 2 comments · May be fixed by KyberNetwork/kyber_reserves_sc#12
Open

bad function call in conversion rate (pricing) #291

ilanDoron opened this issue Aug 28, 2018 · 2 comments · May be fixed by KyberNetwork/kyber_reserves_sc#12
Labels
Conversion Rate contract

Comments

@ilanDoron
Copy link
Contributor

ilanDoron commented Aug 28, 2018 •
edited
Loading

in conversion rate.

smart-contracts/contracts/ConversionRates.sol

Line 227 in 02094d3

qty = getTokenQty(token, rate, qty);

call to getTokenQty(token, rate, qty);
rate and qty are swapped
should be replaced by
getTokenQty(token, qty, rate);

thanks to @namnm1991 for finding this bug...
@manhlx3006
Copy link
Contributor

Fixed with new conversion rate contract in this PR: https://github.com/KyberNetwork/smart-contracts/pull/416/files

@manhlx3006 manhlx3006 mentioned this issue Aug 7, 2019
Merged
@manhlx3006
Copy link
Contributor

This issue should be resolved in enhanced step function contract

@ducquangkstn ducquangkstn linked a pull request Dec 29, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Conversion Rate contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Kyber FPR reserve with qty step functions KyberNetwork/kyber_reserves_sc
2 participants
@ilanDoron @manhlx3006