Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid closing stream by OpenFontReader.ReadPreview #216

Open
acaly opened this issue Oct 17, 2020 · 1 comment
Open

Avoid closing stream by OpenFontReader.ReadPreview #216

acaly opened this issue Oct 17, 2020 · 1 comment

Comments

@acaly
Copy link

acaly commented Oct 17, 2020

When using OpenFontReader to read a font collection, it would be really helpful to keep the stream open such that ReadPreview and Read can be called on the same stream instance. If the stream is seekable, this simplifies the logic a lot, because otherwise we either need to manually make a copy (probably to MemoryStream) or open the file again.
@prepare
Copy link
Member

prepare commented Oct 21, 2020

Thank you , I will check it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@acaly @prepare