Commentary: permalinks: use the anchor (id=) to scroll to position

[grahamperrin]

Requirements

• This is a feature request and not a bug report. Otherwise, please create a new bug report instead.
• Please check to see if this request (or a similar one) already exists.
• It's a single feature. Please don't request multiple features in one issue.

Describe the feature you'd like

Steps to reproduce:

1. click the link icon for a comment

Expected:

2. scroll to position

Actual result:

2. the top of the page – and depending upon the length/height of the opening post, the required comment may be out of sight.

Example

Compare:

• https://blendit.bsd.cafe/comment/1200953
• https://blendit.bsd.cafe/comment/1200953#comment-1200953

Use case

Increase the likelihood of readers seeing what's intended when links are shared.

Context

This enhancement may be complementary to:

• All non-relevent comments should be collapsed or completely hidden when viewing a link to a specific comment. #2370

[grahamperrin]

Workarounds

Browser extensions such as Display #Anchors can display clickable anchors.

An example:

https://github.com/Rob--W/display-anchors

[dessalines]

I'm not sure how this could work, because as you pointed out, there's a chance the comment might not be in the first page of results, or it might be a deeply nested comment.

This is why our post comment links use this: https://lemmy.ml/post/24821043/16114056 , (a context view) which already works.

[grahamperrin]

… comment links … this: lemmy.ml/post/24821043/16114056 , (a context view) which already works.

I see the opening post, not a comment:

[dessalines]

That's because its a long post body, scroll down to the first comment, its the one you linked.

[grahamperrin]

Expected:

2. scroll to position

[dessalines]

Sounds like you can handle this then, I'll assign it to you.

[grahamperrin]

Thanks, can someone point me to relevant files?

(I'm neither a coder, nor a developer, the codebase here is completely unfamiliar to me.)

[dessalines]

Sure, its in https://github.com/LemmyNet/lemmy-ui/blob/main/src/shared/components/post/post.tsx .