-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segmentation Fault in ebusctl in 24.1.0 image #154
Comments
Unfortunatelly, the rollback to 23.2.6 is not working: it produces the same segfault. |
it seems some configuration conversion is made. please not that, the upstream ebusd has the same issue in docker. |
I was not loud enough in the breaking change section of the 24.1.0's PR. 👯 |
Rollback to 23.2.5. The 23.2.6 image seems to already contain ebus 24.1.0 (not sure why). My slightly hacky way (after restoring the backup):
This got my system back into a working state. |
because the last pr only mapped the ha's config to the prebuilt gh package (which was already based on 24.1 (#152) so maybe all the compiled images after 04/12/2024 should be deleted to be able to correctly rollback. |
As a workaround you can do |
If this is only for the precompiled docker image, how about not using that but compiling ebusd instead? - so the inverse of #29 |
How do I roll back if I'm using the HA add-on please? |
See my earlier command: #154 (comment). To use those commands you would have to ssh into your HA and run those commands. That worked for me. |
I can confirm. maybe there is difference between the the edge and the release version in the alpine repo? currently we use 3.18 baseimage. ebusd 24.1 was released only to the edge and 3.21. maybe there is some dependency issue what the apk upgrade resolves. maybe it is the time to upgrade the baseimage as well? |
Using the image/distribution version matching your packages generally sounds like very good advice. Anything preventing us from upgrading? 3.18 is almost end of support anyway. |
looking at Line 11 in 1799bf8
Code Snippet BehaviorSummaryThe code snippet installs the Key Points
we're not running the provided ebus docker images but specifically installing the ebusd package in version 24.1-r0
regardless, i'm evaluating not using a custom image via the Line 15 in 1799bf8
but referencing the offical ebusd image on dockerhub - eg changing this appears to have quite a few implications - removing or heavily modifying the |
The r0 is correct. the key thing, that we use alpine 3.18 basimage: in the repo package manager you can see, that it is only released officially on the "edge" and v3.21: The other releases has only the 23.0-r0. in the dockerfile we add the "edge". -anyways it should not make any sense, but worth to try to update the baseimage, maybe there are other dependencies which is worth to update..... |
the "usual" way of doing this would be to just base your docker image on the official ones. that allows you to put your own customizations as layer on top. this would be a Dockerfile such as:
this way we can stay close to upstream but stlll customize. ideally we try to upstream all customizations over time. EDIT: just checked. i guess you can safely replace the upstream entry point: https://github.com/john30/ebusd/blob/master/contrib/docker/docker-entrypoint.sh with the existing |
thanks for your support. initially set this up using the HomeAssistant addon development documentation. The Alpine Images provided by Home Assistant have bashio installed, which handels the configuration options that users of the addon can set in the Addon Configuration Tab of the Home Assistant UI. so as far as i can tell, we have two options:
|
yes it's provided for all of the platforms (eg) , but I am unsure it will solves our problem, but worth to try to change the Lines 2 to 6 in 1799bf8
|
looks like build.yaml appeard with cf463c5 - but according to the docs, its not required. as for Option 2: we should propably merge this issue with #147 and also consider how to version this addon since our versioning may be confused with ebusd version numbers. or they should always sync but then ebusd would need to update for the addon configuration as discussed here to roll out to other installs. |
I've made a PoC in my repo and it seems it resolves the problem. Now, I've created a PR (#159), lets' check it! Ofc it is not release ready so the https://github.com/LukasGrebe/ha-addons/blob/main/ebusd/CHANGELOG.md and the https://github.com/LukasGrebe/ha-addons/blob/main/ebusd/config.yaml are not updated. After the build It should work in the same way:
and the final test:
|
Fixed with #159 and update to 24.1.1
|
Thanks @cociweb ! |
It is worth to mention from the docs that MQTT Broker server needs to be restarted after the upgrade to get the new entities. |
Thanks @LukasGrebe and @cociweb! |
I just updated the to the new 24.1.0 image. This seems to break ebusctl within the image:
The text was updated successfully, but these errors were encountered: