Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated unittest2 lib #77

Open
ClementWalter opened this issue Apr 13, 2021 · 3 comments · May be fixed by #130
Open

Remove deprecated unittest2 lib #77

ClementWalter opened this issue Apr 13, 2021 · 3 comments · May be fixed by #130

Comments

@ClementWalter
Copy link

I am following from this issue on poetry: python-poetry/poetry#3906

I guess that unittest2 is now deprecated and causes troubles for dependency resolution.
Interestingly enough I see that you are still using old fashioned requirements.txt (which is actually not consistent with a dup). If you would like to, I could upgrade your project to using poetry instead.
@FabianIsensee
Copy link
Member

Hi Clement,
thank you for pointing this out. We would like to have additional dependencies, especially ones that we are not familiar with.
I agree that we should not be using requirements.txt anymore. Batchgenerators has a long history of 'do not touch a running system' :-). I will update it to use a regular setup.py shortly. Is there a low-tech way of fxing the unittest2 problem?
Best,
Fabian

@ClementWalter ClementWalter mentioned this issue Apr 14, 2021
Open
@ClementWalter
Copy link
Author

Actually poetry is not a dependency but a dependency management system. Currently you have deps defined in setup, in requirements, they do not math and are not locking any deps of your project (deps of deps for instance).

I am going to create another PR to show you how it would be

@dyollb
Copy link

dyollb commented Nov 26, 2024

the dependency unittest2 should be optional (or upgraded to simply use unittest).

This can be achieved without poetry, e.g. using standard setuptools. I am happy to send a PR.

@dyollb dyollb linked a pull request Nov 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove dependencies unittest2 and future dyollb/batchgenerators
3 participants
@FabianIsensee @dyollb @ClementWalter