You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the behavior introduced in #17, via the Start scene at cursor command, the scene is started at the line of the cursor (or the whole scene is previewed when the cursor is at a class statement).
This might be problematic when one Python statement is spread over multiple lines. Manim will then fail and the user might not even notice if they don't have their terminal open.
Options to resolve this and more details are provided in this comment:
Propagate this error to the user in a vscode notification
Implement logic to detect the end of the python expression on the selected line
Where the first option would probably be easier to implement. Maybe one could also just open the terminal if an error is encountered?
The text was updated successfully, but these errors were encountered:
I was able to get the stream of an already running terminal with this code. (The code there is really bad, it's just my first attempts to get anything related to the progress indicator to work).
I agree with this comment that we can treat this as an issue for future development. For v0.1.0, we can assume that users are viewing a terminal and can see the error.
With the behavior introduced in #17, via the
Start scene at cursor
command, the scene is started at the line of the cursor (or the whole scene is previewed when the cursor is at aclass
statement).This might be problematic when one Python statement is spread over multiple lines. Manim will then fail and the user might not even notice if they don't have their terminal open.
Options to resolve this and more details are provided in this comment:
Where the first option would probably be easier to implement. Maybe one could also just open the terminal if an error is encountered?
The text was updated successfully, but these errors were encountered: