Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect previewing cell from different class #9

Open
Splines opened this issue Oct 19, 2024 · 2 comments
Open

Detect previewing cell from different class #9

Splines opened this issue Oct 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@Splines
Copy link
Member

Splines commented Oct 19, 2024

The word "currently" refers to code of #8 in this pull request.

Currently, when previewing a cell from one class, then previewing a cell from another class, the new elements are just put on top of the active scene. Instead, we'd probably want to ask the user if they want to quit the active Manim interactive shell and run the manimgl command again with the new class name.

We could reuse code that would be introduced to close #2 beforehand.

@Splines Splines changed the title Detect when previewing cells from different classes Detect previewing cells from different class Oct 19, 2024
@Splines Splines changed the title Detect previewing cells from different class Detect previewing cell from different class Oct 19, 2024
@bhoov
Copy link
Collaborator

bhoov commented Oct 25, 2024

I would also treat this as an enhancement that is not necessary for v0.1.0 -- like Jupyter notebooks, I think it is reasonable for users to understand that they are editing the global state of a backend kernel in the order that cells are run

@bhoov bhoov added the enhancement New feature or request label Oct 25, 2024
@Splines
Copy link
Member Author

Splines commented Nov 17, 2024

With the reload() command in #77, this would be very easy to implement. See also my PR here in the Manim repo. Sorry, nope wouldn't work as manimgl takes the Scene as command parameter, so we cannot just reload(). So we'd have to start entirely. But I do agree that this is really not urgent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants