Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary uses-material-design: true #31

Open
reza00farjam opened this issue May 14, 2024 · 0 comments
Open

Unnecessary uses-material-design: true #31

reza00farjam opened this issue May 14, 2024 · 0 comments

Comments

@reza00farjam
Copy link

First of all, I wanted to say thanks for this amazing package!

The problem that i encountered is that when skeletonizer is used in a project that do not use the material icons (Its uses-material-design is set to false), the following warning will be raised:

package:skeletonizer has `uses-material-design: true` set but the primary pubspec contains `uses-material-design: false`.
If the application needs material icons, then `uses-material-design`  must be set to true.

As I searched in the skelonizer project's directory, there is no important use of Material Icons except for examples and tests, which can be replaced by assets or something else. So, removing uses-material-design: true in skelonizer project's pubspec.yaml will fix the waring mentioned earlier, without causing any new problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant