Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spike] Service Date Range timezone format #878

Open
Alessandro100 opened this issue Jan 14, 2025 · 1 comment
Open

[Spike] Service Date Range timezone format #878

Alessandro100 opened this issue Jan 14, 2025 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Alessandro100
Copy link
Contributor

Alessandro100 commented Jan 14, 2025

Describe the problem

If we look at a validation report example we see the Feed Start Date / Feed End Date formatted as such 2014-10-18. This could cause inaccuracies when working with countries that have different timezones "Japan vs Canada"

Proposed solution

Spike objectives
[] present a way to store Feed Start Date / Feed End Date which includes timezones
[] present a way to compare if the current time is inside the service window. Needed to set the status of the feed
[] present a way to get the timezone from the validation report where there is currently none (by country code?)

Alternatives you've considered

No response

Additional context

No response

@Alessandro100 Alessandro100 added blocked enhancement New feature or request and removed blocked labels Jan 14, 2025
@Alessandro100 Alessandro100 self-assigned this Jan 15, 2025
@Alessandro100
Copy link
Contributor Author

Spike conclusion: We will store the service date range without timezones

Reasoning
Including timezones in the service date would avoid errors in status in a range of +- 12 hours. Since the status is going to be updated daily, there will already be an error range of 23 hours, no use in optimizing for timezones which introduces complexity.

Follow up ticket (future)

  • extract the timezone from agency.txt and save that in datasets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant