Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solvation Specification #362

Open
wavefunction91 opened this issue Dec 2, 2024 · 2 comments
Open

Solvation Specification #362

wavefunction91 opened this issue Dec 2, 2024 · 2 comments

Comments

@wavefunction91
Copy link

wavefunction91 commented Dec 2, 2024

Is your feature request related to a problem? Please describe.

QCSchema (and friends) do not currently expose the ability to (transparently) specify solvation settings. This is a highly desirable feature for the community.

Describe the solution you'd like

It would be desirable to extend the schema to include a solvent data structure to allow for IO specification of solvation settings. Where this lives is not immediately obvious to me - I could see it extending either the molecule schema (to the extent that molecule defines the physical system) or the model schema (to the extent to which one is modifying the model physics - ala method and basis). Wherever this should live, the following items should be made variable

Key Name Description Field Type
name Solvent specification (water, benzene, etc) string
model Solvent model type (PCM, LPB, COSMO-[RS]) string
epsilon Dielectric constant float

Describe alternatives you've considered

It is generally the case that one can specify solvent settings in a program-specific keyword setting, but this is not a satisfying solution for interoperability between codes nor for archiving of data.

@loriab
Copy link
Collaborator

loriab commented Dec 2, 2024

On the Molecule vs. AtomicInput.specification.model choice, I think solvation falls on model. For Molecule, besides identifiers, we've been roughly keeping it limited to things having to do with the atom center coordinates.

EDIT: Also, float or string for epsilon?

@wavefunction91
Copy link
Author

Also, float or string for epsilon?

Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants