Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules mistakenly placed in engine namespace #4571

Closed
keturn opened this issue Mar 11, 2021 · 3 comments
Closed

modules mistakenly placed in engine namespace #4571

keturn opened this issue Mar 11, 2021 · 3 comments
Labels
Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Milestone

Comments

@keturn
Copy link
Member

keturn commented Mar 11, 2021

#4560's migration was applied too broadly and ended up moving some packages in modules instead of just the engine, as in Terasology/Inventory#38

Fixing this doesn't involve changes to the Terasology repo, but an issue here next to #4560 seems a good a place for a tracking issue as any.

Edit: Usurped by #4580 I guess?

@keturn
Copy link
Member Author

keturn commented Mar 11, 2021

There aren't too many of these modules in omega that ended up containing a package org.terasology.engine statement:

but references to some of those like Health and Inventory will have leaked to a lot of dependent modules.

@keturn
Copy link
Member Author

keturn commented Mar 12, 2021

I think the plan for fixing this is:

  1. Decide whether, since we need to correct references in all the dependent modules anyway, we want to make other intentional changes to the namespace of these modules while we're at it. Some discussion of this in organize under single inventory package Terasology/Inventory#37
  2. Make a migration file that explicitly lists each class being moved. Doing recursive migration of packages is how I got us in to this mess!
    • we could migrate packages iff we can confirm that there are not multiple projects adding classes to that package, but once we've started bulk-listing classes it sounds easier to just stick with classes than do that confirmation.
  3. Apply the migration to all omega modules.

@keturn keturn added this to the v4.3.0 milestone Mar 12, 2021
@keturn keturn added Api Blocker Issue reporting or PR addressing a critical problem that blocks other efforts labels Mar 12, 2021
@keturn
Copy link
Member Author

keturn commented Mar 16, 2021

usurped by #4580

@keturn keturn closed this as completed Mar 16, 2021
@skaldarnar skaldarnar added Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc. and removed Api labels May 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Issue reporting or PR addressing a critical problem that blocks other efforts Topic: Architecture Requests, Issues and Changes related to software architecture, programming patterns, etc.
Projects
None yet
Development

No branches or pull requests

2 participants