Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stack(s) to trigger a needinfo? for bugs where we have no bisection #6

Open
choller opened this issue Sep 15, 2020 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@choller
Copy link

choller commented Sep 15, 2020

For some bugs, like TSan or ASan Nightly issues, we usually don't have a bisection (esp. for issues that have been in the codebase for a long time or where we don't have a standalone testcase but a stack.

Using this stack, it would be nice if we could automatically trigger an initial needinfo? based on the first relevant frame. The challenges here are

  1. Finding the first non-generic frame. Sometimes there are a few generic frames on top of the stack that aren't relevant. My gut feeling tells me that we can find heuristics to work around this, e.g. pick the first frame that belongs to a .c|.cpp|.rs file (not .h) that is in our codebase.

  2. If the hg annotate turns up a developer no longer working at Mozilla (which is common for old code), we might have to check the surroundings for other developers that might be able to help.

  3. We have to deal with reformat commits (I believe we have a hg ext to do this already?)

@choller choller added the enhancement New feature or request label Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant