Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeJS GitHub workflow #213

Open
anilnatha opened this issue Oct 24, 2023 · 0 comments
Open

Fix NodeJS GitHub workflow #213

anilnatha opened this issue Oct 24, 2023 · 0 comments

Comments

@anilnatha
Copy link
Contributor

anilnatha commented Oct 24, 2023

Our GH workflow that checks for build issues related to NodeJS versions 14.x, 16.x, and 18.x is failing

A recent PR resolved a couple issues related to the build failures; however, the workflow's jobs continue to fail.

Observations:

  1. The tests for NodeJS 14 and 16 fail after what appears to be a successful build. In my local testing, I found that running npm run test produces one test failure which may be a good starting point as this command is part of the GitHub Workflow.
  2. Running npm run build locally succeeds.
  3. The app presently doesn't run locally when using NodeJS >18.x so this test may need to be removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

1 participant