-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
registry api does not return bundle of a product #133
Comments
works for me with latest code:
|
@al-niessner this ticket, as all high level tickets need to be applied to the branch release/1.0.1 because this is the one in production. If this stays in the PR #142 I will not be able to merge it. |
The fix in PR #142 does not help release 1.0.1 at all. The fix will have to be worked there in a different way due to all of the rewrites on PR #142. Not a surprise at all but it means this ticket will have to be referenced by 2 separate PRs for it to be fixed on all branches. Unlike the query stuff, the fix for this issue does not lend itself to cross branch easiness. Will develop the correct fix on branch release 1.0.1 for this ticket and that code base. |
Cannot duplicate using release 1.0.1 code:
Then here is the curl you present:
Or more succinctly:
Looks alright. Is your database working or is it broken (did not build all references)? Did something change with the test data that breaks the database such that this no longer works? Maybe using wrong code? |
@jimmie @tloubrieu-jpl what version the API do we have deployed on AWS? |
no longer and issue. this query works at pds.nasa.gov curl --location --request GET 'https://pds.nasa.gov/api/search/1.0/products/urn:nasa:pds:insight_rad:data_derived:hp3_rad_der_00014_20181211_073042::1.0/bundles' --header 'Accept: application/json' {
"data" : [
{
"id" : "urn:nasa:pds:insight_rad::2.1",
"investigations" : [
{
"href" : "http://pds.nasa.gov/products/urn:nasa:pds:context:investigation:mission.insight",
"id" : "urn:nasa:pds:context:investigation:mission.insight"
}
],
"metadata" : {
"label_url" : "https://pds-geosciences.wustl.edu/insight/urn-nasa-pds-insight_rad/bundle_insight_rad.xml",
"update_date_time" : "2018-02-01T00:00:00Z",
"version" : "2.1"
},
"observing_system_components" : [
{
"href" : "http://pds.nasa.gov/products/urn:nasa:pds:context:instrument_host:spacecraft.insight",
"id" : "urn:nasa:pds:context:instrument_host:spacecraft.insight"
},
{
"href" : "http://pds.nasa.gov/products/urn:nasa:pds:context:instrument:radiometer.insight",
"id" : "urn:nasa:pds:context:instrument:radiometer.insight"
}
],
"properties" : {
"_package_id" : [
"41632972-f360-4790-9fd9-566dd634d6c7"
],
"description" : [
"The InSight Radiometer data bundle consists of data in three collections: data_raw, data_calibrated, and data_derived. The bundle also includes the HP3/RAD Software Interface Specification in the HP3/RAD document collection.",
"Pre-peer review version",
"First release",
"The collections urn:nasa:pds:insight_rad:data_calibrated and urn:nasa:pds:insight_rad:data_derived were added to this bundle with InSight Release 1b.",
"Changed Observing_System_Component name in this label from RAD to RADIOMETER to match context product name. Expanded Citation_Information description."
],
"lid" : [
"urn:nasa:pds:insight_rad"
],
"lidvid" : [
"urn:nasa:pds:insight_rad::2.1"
],
"ops:Data_File_Info.ops:creation_date_time" : [
"2019-09-12T21:18:40Z"
],
"ops:Data_File_Info.ops:file_name" : [
"readme.txt"
],
"ops:Data_File_Info.ops:file_ref" : [
"https://pds-geosciences.wustl.edu/insight/urn-nasa-pds-insight_rad/readme.txt"
],
"ops:Data_File_Info.ops:file_size" : [
"1114"
],
"ops:Data_File_Info.ops:md5_checksum" : [
"192de32c12437c180a9e14d60fe4b89a"
],
"ops:Data_File_Info.ops:mime_type" : [
"text/plain"
],
"ops:Harvest_Info.ops:harvest_date_time" : [
"2021-11-16T06:02:03.510294400Z"
],
"ops:Harvest_Info.ops:node_name" : [
"PDS_GEO"
],
"ops:Label_File_Info.ops:creation_date_time" : [
"2019-09-12T21:18:40Z"
],
"ops:Label_File_Info.ops:file_name" : [
"bundle_insight_rad.xml"
],
"ops:Label_File_Info.ops:file_ref" : [
"https://pds-geosciences.wustl.edu/insight/urn-nasa-pds-insight_rad/bundle_insight_rad.xml"
],
"ops:Label_File_Info.ops:file_size" : [
"6805"
],
"ops:Label_File_Info.ops:md5_checksum" : [
"adfd86bbf2573c37d862e27e08f332db"
],
"ops:Tracking_Meta.ops:archive_status" : [
"archived"
],
"pds:Bundle.pds:bundle_type" : [
"Archive"
],
"pds:Bundle_Member_Entry.pds:lid_reference" : [
"urn:nasa:pds:insight_rad:data_raw",
"urn:nasa:pds:insight_rad:data_calibrated",
"urn:nasa:pds:insight_rad:data_derived",
"urn:nasa:pds:insight_documents:document_hp3rad"
],
"pds:Bundle_Member_Entry.pds:member_status" : [
"Primary",
"Primary",
"Primary",
"Secondary"
],
"pds:Bundle_Member_Entry.pds:reference_type" : [
"bundle_has_data_collection",
"bundle_has_data_collection",
"bundle_has_data_collection",
"bundle_has_document_collection"
],
"pds:Citation_Information.pds:author_list" : [
"InSight RAD Science Team"
],
"pds:Citation_Information.pds:description" : [
"The InSight Radiometer data bundle consists of data in three collections: data_raw, data_calibrated, and data_derived. The bundle also includes the HP3/RAD Software Interface Specification in the HP3/RAD document collection."
],
"pds:Citation_Information.pds:doi" : [
"10.17189/1517568"
],
"pds:Citation_Information.pds:publication_year" : [
"2018"
],
"pds:File.pds:comment" : [
"Introduction to the bundle"
],
"pds:File.pds:file_name" : [
"readme.txt"
],
"pds:Identification_Area.pds:information_model_version" : [
"1.11.0.0"
],
"pds:Identification_Area.pds:logical_identifier" : [
"urn:nasa:pds:insight_rad"
],
"pds:Identification_Area.pds:product_class" : [
"Product_Bundle"
],
"pds:Identification_Area.pds:title" : [
"Mars InSight Lander Radiometer Data Archive"
],
"pds:Identification_Area.pds:version_id" : [
"2.1"
],
"pds:Internal_Reference.pds:lid_reference" : [
"urn:nasa:pds:context:investigation:mission.insight",
"urn:nasa:pds:context:instrument_host:spacecraft.insight",
"urn:nasa:pds:context:instrument:radiometer.insight",
"urn:nasa:pds:context:target:planet.mars"
],
"pds:Internal_Reference.pds:reference_type" : [
"bundle_to_investigation",
"is_instrument_host",
"is_instrument",
"bundle_to_target"
],
"pds:Investigation_Area.pds:name" : [
"InSight"
],
"pds:Investigation_Area.pds:type" : [
"Mission"
],
"pds:Modification_Detail.pds:description" : [
"Pre-peer review version",
"First release",
"The collections urn:nasa:pds:insight_rad:data_calibrated and urn:nasa:pds:insight_rad:data_derived were added to this bundle with InSight Release 1b.",
"Changed Observing_System_Component name in this label from RAD to RADIOMETER to match context product name. Expanded Citation_Information description."
],
"pds:Modification_Detail.pds:modification_date" : [
"2018-02-01T00:00:00Z",
"2019-04-22T00:00:00Z",
"2019-06-11T00:00:00Z",
"2020-01-02T00:00:00Z"
],
"pds:Modification_Detail.pds:version_id" : [
"0.1",
"1.0",
"2.0",
"2.1"
],
"pds:Observing_System.pds:name" : [
"InSight"
],
"pds:Observing_System_Component.pds:name" : [
"InSight",
"RADIOMETER"
],
"pds:Observing_System_Component.pds:type" : [
"Spacecraft",
"Instrument"
],
"pds:Primary_Result_Summary.pds:processing_level" : [
"Raw",
"Calibrated",
"Derived"
],
"pds:Primary_Result_Summary.pds:purpose" : [
"Science"
],
"pds:Science_Facets.pds:discipline_name" : [
"Geosciences"
],
"pds:Science_Facets.pds:domain" : [
"Surface"
],
"pds:Stream_Text.pds:local_identifier" : [
"BUNDLE.DESCRIPTION"
],
"pds:Stream_Text.pds:name" : [
"Introduction to the Radiometer Data Bundle"
],
"pds:Stream_Text.pds:offset" : [
"0"
],
"pds:Stream_Text.pds:parsing_standard_id" : [
"7-Bit ASCII Text"
],
"pds:Stream_Text.pds:record_delimiter" : [
"Carriage-Return Line-Feed"
],
"pds:Target_Identification.pds:name" : [
"Mars"
],
"pds:Target_Identification.pds:type" : [
"Planet"
],
"pds:Time_Coordinates.pds:start_date_time" : [
"2018-05-05T00:00:00Z"
],
"pds:Time_Coordinates.pds:stop_date_time" : [
"3000-01-01T00:00:00.000Z"
],
"product_class" : [
"Product_Bundle"
],
"ref_lid_collection" : [
"urn:nasa:pds:insight_rad:data_calibrated",
"urn:nasa:pds:insight_rad:data_derived",
"urn:nasa:pds:insight_rad:data_raw"
],
"ref_lid_collection_secondary" : [
"urn:nasa:pds:insight_documents:document_hp3rad"
],
"ref_lid_instrument" : [
"urn:nasa:pds:context:instrument:radiometer.insight"
],
"ref_lid_instrument_host" : [
"urn:nasa:pds:context:instrument_host:spacecraft.insight"
],
"ref_lid_investigation" : [
"urn:nasa:pds:context:investigation:mission.insight"
],
"ref_lid_target" : [
"urn:nasa:pds:context:target:planet.mars"
],
"title" : [
"Mars InSight Lander Radiometer Data Archive"
],
"vid" : [
"2.1"
]
},
"start_date_time" : "2018-05-05T00:00:00Z",
"stop_date_time" : "3000-01-01T00:00:00.000Z",
"targets" : [
{
"href" : "http://pds.nasa.gov/products/urn:nasa:pds:context:target:planet.mars",
"id" : "urn:nasa:pds:context:target:planet.mars"
}
],
"title" : "Mars InSight Lander Radiometer Data Archive",
"type" : "Product_Bundle"
}
],
"summary" : {
"hits" : 1,
"limit" : 100,
"properties" : [
"_package_id",
"description",
"lid",
"lidvid",
"ops:Data_File_Info.ops:creation_date_time",
"ops:Data_File_Info.ops:file_name",
"ops:Data_File_Info.ops:file_ref",
"ops:Data_File_Info.ops:file_size",
"ops:Data_File_Info.ops:md5_checksum",
"ops:Data_File_Info.ops:mime_type",
"ops:Harvest_Info.ops:harvest_date_time",
"ops:Harvest_Info.ops:node_name",
"ops:Label_File_Info.ops:creation_date_time",
"ops:Label_File_Info.ops:file_name",
"ops:Label_File_Info.ops:file_ref",
"ops:Label_File_Info.ops:file_size",
"ops:Label_File_Info.ops:md5_checksum",
"ops:Tracking_Meta.ops:archive_status",
"pds:Bundle.pds:bundle_type",
"pds:Bundle_Member_Entry.pds:lid_reference",
"pds:Bundle_Member_Entry.pds:member_status",
"pds:Bundle_Member_Entry.pds:reference_type",
"pds:Citation_Information.pds:author_list",
"pds:Citation_Information.pds:description",
"pds:Citation_Information.pds:doi",
"pds:Citation_Information.pds:publication_year",
"pds:File.pds:comment",
"pds:File.pds:file_name",
"pds:Identification_Area.pds:information_model_version",
"pds:Identification_Area.pds:logical_identifier",
"pds:Identification_Area.pds:product_class",
"pds:Identification_Area.pds:title",
"pds:Identification_Area.pds:version_id",
"pds:Internal_Reference.pds:lid_reference",
"pds:Internal_Reference.pds:reference_type",
"pds:Investigation_Area.pds:name",
"pds:Investigation_Area.pds:type",
"pds:Modification_Detail.pds:description",
"pds:Modification_Detail.pds:modification_date",
"pds:Modification_Detail.pds:version_id",
"pds:Observing_System.pds:name",
"pds:Observing_System_Component.pds:name",
"pds:Observing_System_Component.pds:type",
"pds:Primary_Result_Summary.pds:processing_level",
"pds:Primary_Result_Summary.pds:purpose",
"pds:Science_Facets.pds:discipline_name",
"pds:Science_Facets.pds:domain",
"pds:Stream_Text.pds:local_identifier",
"pds:Stream_Text.pds:name",
"pds:Stream_Text.pds:offset",
"pds:Stream_Text.pds:parsing_standard_id",
"pds:Stream_Text.pds:record_delimiter",
"pds:Target_Identification.pds:name",
"pds:Target_Identification.pds:type",
"pds:Time_Coordinates.pds:start_date_time",
"pds:Time_Coordinates.pds:stop_date_time",
"product_class",
"ref_lid_collection",
"ref_lid_collection_secondary",
"ref_lid_instrument",
"ref_lid_instrument_host",
"ref_lid_investigation",
"ref_lid_target",
"title",
"vid"
],
"q" : "",
"sort" : [],
"start" : 0,
"took" : 737
}
}
|
The version deployed on AWS is 1.0.0. The latest stable version, since yesterday is 1.0.1. I will close this ticket. |
🐛 Describe the bug
When I want to get the bundle embedding a product I am not getting a result.
📜 To Reproduce
Test with the following request on the test dataset:
curl --location --request GET 'http://localhost:8080/products/urn:nasa:pds:insight_rad:data_derived:hp3_rad_der_00014_20181211_073042::1.0/bundles'
--header 'Accept: application/json'
Returns:
{
"summary": {
"q": "",
"hits": 0,
"took": 125,
"start": 0,
"limit": 100,
"sort": [],
"properties": []
},
"data": []
}
🕵️ Expected behavior
The data property should be filled with the description of the bundle embedding the product.
📚 Version of Software Used
The bug was found using the docker compose deployment on registry repository main branch using this docker image https://hub.docker.com/layers/registry-api-service/nasapds/registry-api-service/latest/images/sha256-b98500e7ed14a6eeee70e26bcd9a27c079e1d8ec4bda04ae56246a09f9b02ac2?context=explore
🩺 Test Data / Additional context
🏞Screenshots
🖥 System Info
🦄 Related requirements
⚙️ Engineering Details
The text was updated successfully, but these errors were encountered: