Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API silently ignores bad/unsupported query parameters in requests #237

Closed
alexdunnjpl opened this issue Jan 19, 2023 · 1 comment
Closed
Assignees
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@alexdunnjpl
Copy link
Contributor

alexdunnjpl commented Jan 19, 2023

🐛 Describe the bug

API silently ignores bad/unsupported query parameters in requests. This can confuse users as the API will respond with an unfiltered list of all resources the user is attempting to filter on.

📜 To Reproduce

Steps to reproduce the behavior:

  1. Curl or browse https://pds.nasa.gov/api/search/1/classes/collections?identifier=urn%3Anasa%3Apds%3Ainsight_rad%3Adata_derived%3A%3A7.0
  2. Observe that response returns query equivalent to https://pds.nasa.gov/api/search/1/classes/collections with a blank query string q=""

🕵️ Expected behavior

Presence of unexpected query parameters should (maybe) return HTTP400 bad request

📚 Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

🦄 Related requirements

⚙️ Engineering Details

@tloubrieu-jpl
Copy link
Member

duplicate of NASA-PDS/pds-api#252

@tloubrieu-jpl tloubrieu-jpl added duplicate This issue or pull request already exists and removed needs:triage labels Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants