Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a user, I want to receive a XML response that contains the PDS4 label metadata in XML format (application/vnd.nasa.pds.pds4+xml) #440

Open
tloubrieu-jpl opened this issue Oct 18, 2021 · 3 comments
Assignees

Comments

@tloubrieu-jpl
Copy link
Member

💪 Motivation

...so that I can get the original label from the API

📖 Additional Details

We need to reimplement the 'application/pds4+xml' MVC implementation on top of the PDS4Product object (instead of previously on top of the default Product object)

⚖️ Acceptance Criteria

Given a valid lidvid in the registry
When I perform curl -X GET http://{base_url}/products/{lidvid} --header Accept: application/pds+xml
Then I expect to get the original PDS4 XML label for the lidvid

When I perform curl -X GET http://{base_url}/products --header Accept: application/pds+xml
Then I expect to get the search result with original PDS4 XML labels

⚙️ Engineering Details

@tloubrieu-jpl tloubrieu-jpl added requirement the current issue is a requirement needs:triage labels Oct 18, 2021
@jordanpadams jordanpadams changed the title As a ser, I want to get the PDS4 original XML label As a user, I want to get the PDS4 original XML label Oct 18, 2021
@jordanpadams jordanpadams removed their assignment Oct 26, 2021
@jordanpadams jordanpadams changed the title As a user, I want to get the PDS4 original XML label As a user, I want to get the metadata in a pds4+xml response Nov 9, 2021
@tloubrieu-jpl
Copy link
Member Author

This ticket is not closed after pull request NASA-PDS/registry-api-service#90

@al-niessner
Copy link
Contributor

@tloubrieu-jpl @jordanpadams

Oh, I think I understand. I turned application/pds4+xml and application/xml back "on" such that they go through the translation mechanisms. They fail for reasons I do not fully understand when building the XML, which is to say the results are retrieved from ES then fails to be remapped to XML. They both seem to fail for similar reasons. Should probably just fix both at the same time. Something about the converter resolution and null type failure:

2021-12-21 21:40:14.328 DEBUG 54 --- [0.3-8080-exec-8] o.s.w.s.m.m.a.HttpEntityMethodProcessor  : Using 'application/pds4+xml', given [application/pds4+xml] and supported [application/pds4+xml, */*]
2021-12-21 21:40:14.328  WARN 54 --- [0.3-8080-exec-8] .w.s.m.s.DefaultHandlerExceptionResolver : Resolved [org.springframework.http.converter.HttpMessageNotWritableException: No converter for [class gov.nasa.pds.model.Pds4Products] with preset Content-Type 'null']
2021-12-21 21:40:14.328 DEBUG 54 --- [0.3-8080-exec-8] o.s.web.servlet.DispatcherServlet        : Completed 500 INTERNAL_SERVER_ERROR

@al-niessner
Copy link
Contributor

@tloubrieu-jpl @jordanpadams

Same process question: with the PR merged, should this ticket still be open?

@tloubrieu-jpl tloubrieu-jpl reopened this Feb 24, 2022
@jordanpadams jordanpadams changed the title As a user, I want to get the metadata in a pds4+xml response As a user, I want to receive a XML response that contains the PDS4 label metadata in XML format (application/vnd.nasa.pds.pds4+xml) Sep 2, 2022
@jordanpadams jordanpadams transferred this issue from NASA-PDS/pds-api May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

4 participants