Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transform does not respect value_offset in conversion #17

Open
msbentley opened this issue Nov 8, 2019 · 2 comments
Open

transform does not respect value_offset in conversion #17

msbentley opened this issue Nov 8, 2019 · 2 comments

Comments

@msbentley
Copy link

Describe the bug
I am converting a binary table to csv and a field in the table uses value_offset, however this offset is not applied to the values in the resulting output.

Expected behavior
Decoded values should be modified by value_offset - and also by scaling_factor if present (in my case it was not).

Desktop (please complete the following information):

@msbentley msbentley added the bug Something isn't working label Nov 8, 2019
@msbentley
Copy link
Author

Adding a sample file. Values in the raw data are: 0, 32768, 2147483648, 4294967295.

With <value_offset>1</value_offset> in the label the python viewer shows this correctly:

fits_test.zip

image

but the output of transform -a -f csv -t fits_test_k.xml gives:

0
32768
2147483648
4294967295

@msbentley
Copy link
Author

Ahhhh, I see - this is carried forward to the label of the CSV file - OK, my bad - feel free to close this ticket. I was expected the data to be transformed, and actually didn't care about the label in this case and had not looked at it. But understood now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ToDo
Development

No branches or pull requests

4 participants