Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change handling of GENERAL cards #100

Open
dericed opened this issue Jul 18, 2024 · 4 comments
Open

change handling of GENERAL cards #100

dericed opened this issue Jul 18, 2024 · 4 comments

Comments

@dericed
Copy link
Collaborator

dericed commented Jul 18, 2024

If the camera card type isn't identified then the camera cards script deviates from its usual behavior and adds this interview:

nmaahcmm/camera_cards

Lines 418 to 440 in 76946ca

if [[ "${TAR}" == "NO" ]] && [[ -z "${CAMERA_CARD_TYPE}" ]] ; then
CAMERA_CARD_TYPE="GENERAL"
_report -b "Camera card type not identified!"
echo
printf "Select a strategy:"
echo
PS3="Selection: "
select STRATEGY in "1. Create AIP: concatenate video files and restructure metadata directories" "2. Tar: Compress camera files and folders into a tarball" "3. Both: Create AIP and also tar original package (produces two packages)" "quit"
do
if [[ "${STRATEGY}" == "1. Create AIP: concatenate video files and restructure metadata directories" ]] ; then
TAR="NO"
AIP="YES"
elif [[ "${STRATEGY}" == "2. Tar: Compress camera files and folders into a tarball" ]] ; then
TAR="YES"
AIP="NO"
elif [[ "${STRATEGY}" == "3. Both: Create AIP and also tar original package (produces two packages)" ]] ; then
TAR="YES"
AIP="YES"
fi
if [[ "${STRATEGY}" == "quit" ]] ; then echo "Bye" && exit 0 ; fi
break
done
fi

OK if I remove this part and simply proceed with the overall TAR/AIP settings?

@chialinchou1
Copy link
Collaborator

Yes, I think we can remove "select a strategy" part, but should print to the screen that the Camera card type not identified. creating TAR/AIP....

@dericed
Copy link
Collaborator Author

dericed commented Jul 18, 2024

I can use GENERAL as the fallback for an unidentified card. I was thinking, if the card is GENERAL, then we could find the most popular video extension in the card and just process those files.

@chialinchou1
Copy link
Collaborator

That sounds good. So the TAR setting will just be an option. If no video files can be found/identified, we just logged it and get human interventions...

@dericed
Copy link
Collaborator Author

dericed commented Jul 18, 2024

Ok, here's the update 220b094

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants