Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkvnote - gtk dialog crash when using quotes #117

Open
BleakleyMcD opened this issue Jan 11, 2025 · 2 comments
Open

mkvnote - gtk dialog crash when using quotes #117

BleakleyMcD opened this issue Jan 11, 2025 · 2 comments

Comments

@BleakleyMcD
Copy link
Member

testing this in both main and some-ui-updates branches.

embedding this text into DESCRIPTION tag:

Langston Hughes, working for the Jamaican Government in Washington, lots of contact with Andrew Young.

Andy Young once called me and said "Sandy I saw an article brought to my attention in a Jamaican Newspaper that the CIA was messing with Jamaica because of Manley and his relationship with Castro. I'm not sure if you are messing with us but this is serious but Carter directed me to find out who if anyone is behind this and I asked (a govt person) and they said this is not true. Can you find out for me Sandy"

So Sandy checked it and called his contacts in Jamaica and his contact and he said no this is actually going on the CIA is trying to ruin the Jamaican tourist trade by saying bad things about Jamaica to scare people away.

terminal output after embedding:

Enter your choice: 1
2025-01-11 14:24:20.738 gtkdialog[76532:4710314] *** WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead. 
CATALOG_NUMBER=""
COLLECTION=""
DATE_DIGITIZED=""
DATE_TAGGED=""
DESCRIPTION="Langston Hughes, working for the Jamaican Government in Washington, lots of contact with Andrew Young.

Andy Young once called me and said "Sandy I saw an article brought to my attention in a Jamaican  Newspaper that the CIA was messing with Jamaica because of Manley and his relationship with Castro. I'm not sure if you are messing with us but this is serious but Carter directed me to find out who if anyone is behind this and I asked (a govt person) and they said this is not true. Can you find out for me Sandy"

So Sandy checked it and called his contacts in Jamaica and his contact and he said no this is actually going on the CIA is trying to ruin the Jamaican tourist trade by saying bad things about Jamaica to scare people away."
ENCODED_BY=""
ENCODER="Lavf59.27.100"
ENCODER_SETTINGS=""
ORIGINAL_MEDIA_TYPE=""
TERMS_OF_USE=""
TITLE=""
_ORIGINAL_FPS=""
_TECHNICAL_NOTES=""
EXIT="Tag-On!"
CATALOG_NUMBER ... 
COLLECTION ... 
DATE_DIGITIZED ... 
DATE_TAGGED ... 
DESCRIPTION ... Langston Hughes, working for the Jamaican Government in Washington, lots of contact with Andrew Young.

Andy Young once called me and said "Sandy I saw an article brought to my attention in a Jamaican  Newspaper that the CIA was messing with Jamaica because of Manley and his relationship with Castro. I'm not sure if you are messing with us but this is serious but Carter directed me to find out who if anyone is behind this and I asked (a govt person) and they said this is not true. Can you find out for me Sandy
 ... 
So Sandy checked it and called his contacts in Jamaica and his contact and he said no this is actually going on the CIA is trying to ruin the Jamaican tourist trade by saying bad things about Jamaica to scare people away.
ENCODED_BY ... 
ENCODER ... Lavf59.27.100
ENCODER_SETTINGS ... 
ORIGINAL_MEDIA_TYPE ... 
TERMS_OF_USE ... 
TITLE ... 
_ORIGINAL_FPS ... 
_TECHNICAL_NOTES ... 
The file is being analyzed.
The changes are written to the file.
Done.
 _________________________________________
/ Cool. Done. Enjoy. Tag-on.              \
| /Users/bleakley/Desktop/DRIVE_04/NMAAHC |
| _04/JPC/20240102/JPC_AV_01637/JPC_AV_01 |
\ 637.mkv.                          /
 -----------------------------------------
        \   ^__^
         \  (oo)\_______
            (__)\       )\/\
                ||----w |
                ||     ||
                                                                                                                 
(base) /Users/bleakley/github/nmaahc/nmaahcmm
≈:≈ 

A couple of issues there:

  1. why are the tags repeating?
  2. EXIT="Tag-On!" is a cool tag but we don't need/want it.
  3. The repeated DESCRIPTION tag value is not exactly the same with the second one missing some of the quotation marks. Looks like the quotations maybe triggered a new (unnamed) tag?

More importantly, but probably related, gtk dialog now won't open the file when running mkvnote again:

Enter your choice: 1
2025-01-11 14:34:27.659 gtkdialog[77433:4719593] *** WARNING: Method userSpaceScaleFactor in class NSView is deprecated on 10.7 and later. It should not be used in new applications. Use convertRectToBacking: instead. 

** (gtkdialog:77433): ERROR **: 14:34:27.660: gtkdialog: Error in line 33, near token '</variable>': syntax error
                                                                                                                 
(base) /Users/bleakley/github/nmaahc/nmaahcmm
≈:≈ 

I can open it with the older text file based mkvnote:

# Feel welcome to catalog JPC_AV_01637.mkv here and then save this document. The resulting metadata (if any) will be embedded into the file. You may add new tags as long as the structure is: tag_name=[tag_value].
# These tags semantically are intended to describe the file as a whole and not intended to specifically refer to a particular track or attachment or other sort of piece of the file.
# Empty tags will be ignored.

# These tags already exist in the file. If you edit them here they will be overwritten when saved.
DESCRIPTION=[Langston Hughes, working for the Jamaican Government in Washington, lots of contact with Andrew Young.

Andy Young once called me and said "Sandy I saw an article brought to my attention in a Jamaican  Newspaper that the CIA was messing with Jamaica because of Manley and his relationship with Castro. I'm not sure if you are messing with us but this is serious but Carter directed me to find out who if anyone is behind this and I asked (a govt person) and they said this is not true. Can you find out for me Sandy]
=[
So Sandy checked it and called his contacts in Jamaica and his contact and he said no this is actually going on the CIA is trying to ruin the Jamaican tourist trade by saying bad things about Jamaica to scare people away.]
ENCODER=[Lavf59.27.100]

# These tags already exist in the file. If you edit them here they will be overwritten when saved.
title=[]
coding_history=[]
camera_make_model=[]
camera_card_script=[]
content_description=[]
identifier=[]
alternate_identifier=[]
original_projection_speed=[]
originating_format=[]
creator=[]

When I delete the quotes everything seems to work fine, including nice line breaks in the gui:
Screenshot 2025-01-11 at 14 56 24

@dericed are quotes a no no for any tag data? is the CIA putting boogers in the code?

@BleakleyMcD
Copy link
Member Author

@dericed confirming quotes are to be avoided in the tag data. yes?

@dericed
Copy link
Collaborator

dericed commented Feb 18, 2025

please retest with the latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants