Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit pollutant and erosion calculations to a selected polygon area #87

Open
2 tasks done
NSPECT opened this issue Mar 28, 2022 · 5 comments
Open
2 tasks done

Limit pollutant and erosion calculations to a selected polygon area #87

NSPECT opened this issue Mar 28, 2022 · 5 comments

Comments

@NSPECT
Copy link
Collaborator

NSPECT commented Mar 28, 2022

Latest QNSPECT version

  • I am running the latest QNSPECT version

Similar requests do not exist

  • I have searched existing issues to make sure a similar request does not exist

Feature description

Somehow we completely missed the functionality to only run over a selected subset of watersheds/catchments in an Area of Interest. This was initially done to save run time. The current tool is even slower, so it may be worth investigating.

Additional context

No response

@ar-siddiqui
Copy link
Collaborator

#74 requests a similar feature.

I don't think analysis algorithms should worry about working with subsets. This should be handled in Data Preparation > Align Rasters as requested by #74. Doing this in analysis algorithms is against the design philosophies initially discussed:

  1. The separation of concerns: The analysis modules should only do its part and the data preparation should happen beforehand.
  2. Data preparation should happen only once. Masking rasters in analysis modules would mean that in every run, the tool would first run the Align Rasters internally.

IMO this should be closed and #74 implemented.

@DaveEslinger
Copy link
Member

This is a very common use case. For example, here is an actual instance: a user wanted to study pollution & erosion over an entire island. They got all needed data sets, aligned them, but found processing as one entire area took too long. They then were able to run the same scenario multiple times, just selecting different watershed polygons. There was a clip, or mask, on-the-fly that was applied and didn't really slow down the processing.

Requiring a completely different set of data to be extracted for each sub-area is not a desired solution. However, with the current work flow, this may be difficult.

@ar-siddiqui
Copy link
Collaborator

I see. Just for awareness and future reference, this might be possible to do with the first release as well using QGIS batch processing once #74 is implemented.

In fact, it would happen with just a couple of steps vs running the model multiple times. Although it might take some preparation and setup.

@DaveEslinger
Copy link
Member

Excellent, I am hoping it can be done. It would be ideal for batch use. In fact, for a batch setting, it would probably be easiest to have the polygon areas be different layers, instead of different selections of the same layer. I'm not sure how that would work. But having a bunch of saved polygons is much easier to manage than a bunch of saved raster groups.

@ar-siddiqui
Copy link
Collaborator

I think writing up a few blog posts and example tutorials on different use cases will be one way to show the tool's true prowess in conjunction with QGIS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants