Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bad debug output #1

Open
nonword opened this issue May 24, 2017 · 0 comments
Open

Bad debug output #1

nonword opened this issue May 24, 2017 · 0 comments

Comments

@nonword
Copy link
Member

nonword commented May 24, 2017

Lib should be less chatty when LOG_LEVEL=info.

Also this: https://github.com/NYPL-discovery/node-nypl-streams-client/blob/master/lib/client.js#L84 produces this:

Successfully sent ,, to IndexDocumentQueue kinesis.

..if records don't have a id property. Bad assumption. Should select a different property or just output a truncated form of JSON.stringify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nonword