Prepare for 1.28.4

[jspenguin2017]

No description provided.

[jspenguin2017]

Reviewed until: gorhill@dd6f41a

[jspenguin2017]

TODO:

gorhill@9f7e5b6#diff-f07543d67611389c7e052689c156a214
gorhill@5f4e6d8#diff-5c490989a776cfd759127df7a1241973
gorhill@162e537#diff-5c490989a776cfd759127df7a1241973

Check to make sure the popup, the dashboard, and the logger look good.

[jspenguin2017]

TODO:

The branches are kind of messy at the moment, to be safe:

• Check to make sure:
  • The popup looks good
  • All buttons fit inside the toolbar properly
• Check to make sure:
  • The settings page look good
  • The 3 buttons are on the left side
  • The 3 buttons have the same width and the width is reasonable
• Retest above in incognito mode

[jspenguin2017]

TODO:

gorhill@01b1ed9 (Big)
gorhill@6633e26 (Small)
gorhill@2ba4312 (Small)
gorhill@f869348 (Small)
gorhill@41523d2 (Medium)
gorhill@5752ad5 (Medium)
gorhill@58c6baf (Medium)
gorhill@08eca13 (Small)
gorhill@bc7f149 (Medium)
gorhill@d784fda (Small)
gorhill@6926030 (Medium)
gorhill@1a082e0 (Big)
gorhill@a211c2c (Big)
gorhill@2523959 (Medium)
gorhill@6d8b310 (Big)
gorhill@0e32e43 (Medium)
gorhill@f8b0ee0 (Small)
gorhill@3e72a47 (Medium)
gorhill@c9cfd62 (Medium)
gorhill@aa000e2 (Medium)
gorhill@86d28b5 (Small)
gorhill@db198b0 (Small)
gorhill@c6397e3 (Small)

1p-filters.html, 1p-filters.js, asset-viewer.html, and asset-viewer.js have changed.

May need to reimplement linting rules.

Need to reimplement type normalization for $iframe.

It looks like uBO got a new syntax highlighter, need to reevaluate whether Nano Highlighter is still needed.

The filter editor of uBO got some upgrades such as bracket matching, bracket auto-closing, comments toggle, and auto-complete. Need to evaluate if it is better to ditch Nano Editor and reimplement Nano Linter on top of the filter editor of uBO.

Check to make sure syntax highlighting looks good (for advanced settings, whitelists, user filters, and assets viewer).

Local IP detection logic moved to static-filtering-parser.js file (may need to update docs).

This is a really big change, need to run through the extended checklist like last time.

[jspenguin2017]

I need some time to think about this, as these changes impact the core features (highlighter and linter) of Nano Adblocker.