-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Name does not work. #4
Comments
Looking through the design it appears the original plugin this was built from only corrected upper/lower case differences between interfaces and templates. If an interface name contains a different character, or is missing a character, then it is being picked up as an entirely different interface. I agree that this is not the most useful capability in its current state as it would only apply to one very specific and unlikely circumstance, accidentally changing the case of a character in the interface name, which would be a rare occurrence I would think. I can see what the original designer was trying to accomplish, but I also see why the limitation is in place. If the interface name is "different" in that is has added/removed characters how would the plugin know that is not a net-new interface when all it does is compares it against the name in a device type. I will delve into the logic here and see what I can come up with. Off the top of my head I am thinking that because the plugin wouldn't know if an interface on an existing device with a different name form the template wasn't an interface to remove, what if rather than a fix operation being exclusive from a remove operation (being as the plugin only lets you do one or the other currently and rarely presents a fix) we went with something like an interface having remove OR fix as an option? |
Hi, |
I’m thinking more along the line of having the option of removing or renaming. If the plug-in detects that you have an interface that does not match the template it would give you the option to remove or rename it not just one or the other. Kind of like a checkbox to remove it or a text field to rename it. But because there is no matching interface in the template from which to derive the name, the name would have to be changed manually I think.
…Sent from my iPhone
On May 24, 2024, at 7:57 AM, LordZorgon ***@***.***> wrote:
ATTENTION! This message was sent from an external source, and did not originate from Lethbridge College. Please use caution before replying, clicking links, or opening attachments, as this may be a phishing attempt.
Hi,
thanks for your work on the problem, but I am not quite sure if I understood your last paragraph correct. Is your Idea to merch the fix and the remove button to one fix OR remove button?
—
Reply to this email directly, view it on GitHub<#4 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A6WOKU2XIL4L2QK5H3DAJLTZD5BMNAVCNFSM6AAAAABIHHDTP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRZGYYDKNBVGU>.
You are receiving this because you were assigned.Message ID: ***@***.***>
________________________________
This communication is privileged, confidential, subject to copyright and may contain personal information. Please contact the sender immediately if you are not the intended recipient. Any unauthorized use or disclosure is prohibited. If received in error, this message should be deleted or destroyed.
________________________________
This communication is privileged, confidential, subject to copyright and may contain personal information. Please contact the sender immediately if you are not the intended recipient. Any unauthorized use or disclosure is prohibited. If received in error, this message should be deleted or destroyed.
|
Ah ok, so an extra text box in case you want to change the name, because that has to be done manually, and if you want to create a new one, you can still tick a box to delete it. |
Hello there,
the Problem is, that when a Interface has the wrong name, the Plugin seems to acknowledge it, as a wrong Interface and I can only delete it and create a new one. So the hole point of the 'Fix Name" Option does not work.
If you need any further information, don´t hesitate to ask me.
Have a nice day.
The text was updated successfully, but these errors were encountered: