Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Name does not work. #4

Open
LordZorgon opened this issue May 24, 2024 · 4 comments
Open

Fix Name does not work. #4

LordZorgon opened this issue May 24, 2024 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@LordZorgon
Copy link

Hello there,
the Problem is, that when a Interface has the wrong name, the Plugin seems to acknowledge it, as a wrong Interface and I can only delete it and create a new one. So the hole point of the 'Fix Name" Option does not work.
If you need any further information, don´t hesitate to ask me.
Have a nice day.

@NetTech2001
Copy link
Owner

Looking through the design it appears the original plugin this was built from only corrected upper/lower case differences between interfaces and templates. If an interface name contains a different character, or is missing a character, then it is being picked up as an entirely different interface. I agree that this is not the most useful capability in its current state as it would only apply to one very specific and unlikely circumstance, accidentally changing the case of a character in the interface name, which would be a rare occurrence I would think.

I can see what the original designer was trying to accomplish, but I also see why the limitation is in place. If the interface name is "different" in that is has added/removed characters how would the plugin know that is not a net-new interface when all it does is compares it against the name in a device type. I will delve into the logic here and see what I can come up with.

Off the top of my head I am thinking that because the plugin wouldn't know if an interface on an existing device with a different name form the template wasn't an interface to remove, what if rather than a fix operation being exclusive from a remove operation (being as the plugin only lets you do one or the other currently and rarely presents a fix) we went with something like an interface having remove OR fix as an option?

@NetTech2001 NetTech2001 added the enhancement New feature or request label May 24, 2024
@NetTech2001 NetTech2001 self-assigned this May 24, 2024
@LordZorgon
Copy link
Author

Hi,
thanks for your work on the problem, but I am not quite sure if I understood your last paragraph correct. Is your Idea to merch the fix and the remove button to one fix OR remove button?

@NetTech2001
Copy link
Owner

NetTech2001 commented May 24, 2024 via email

@LordZorgon
Copy link
Author

Ah ok, so an extra text box in case you want to change the name, because that has to be done manually, and if you want to create a new one, you can still tick a box to delete it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants