Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

packages.lock.json incorrectly updated for .NET 5 #1086

Open
1 of 7 tasks
Bouke opened this issue Jan 14, 2021 · 7 comments
Open
1 of 7 tasks

packages.lock.json incorrectly updated for .NET 5 #1086

Bouke opened this issue Jan 14, 2021 · 7 comments
Labels

Comments

@Bouke
Copy link
Contributor

Bouke commented Jan 14, 2021

🐛 Bug Report

I have some projects that multi-target .NET Framework 4.8 and .NET 5:

I have enabled (packages.lock.json):

When NuKeeper tries to update dependencies in such a library, the lock file is incorrectly modified to refer to ".NET Framework v5":

diff --git a/Library/packages.lock.json b/Library/packages.lock.json
index 8c0d8df4d..ef34bdeb6 100644
--- a/Library/packages.lock.json
+++ b/Library/packages.lock.json
@@ -59,7 +59,7 @@
         "contentHash": "NfmC8NoxrRtw2PSmqSu+kVTcsJuMhspxWKbVzrtPxw+O8hjpCPzD0IttCUJclDf36qkmScvvd1BgRHYE17zF9g=="
       }
     },
-    ".NETCoreApp,Version=v5.0": {
+    ".NETFramework,Version=v5.0": {
       "IDisposableAnalyzers": {
         "type": "Direct",
         "requested": "[3.4.8, )",

Expected behavior

It shouldn't modify the reference to .NET 5.

Reproduction steps

See above.

Configuration

Version: 0.4.43

Platform if applicable:

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker
@CrispyDrone
Copy link
Contributor

Hi @Bouke

Would it be possible to include log files with verbosity detailed?

@Bouke
Copy link
Contributor Author

Bouke commented Jan 25, 2021

I'm trying to get those logs, but apparently I was running an old version (0.26.0) due to this bug: NuKeeperDotNet/NuKeeper-AzureDevops-extension#62. Since upgrading my custom package sources aren't being used anymore, running into this bug: #1035 (comment).

@stale
Copy link

stale bot commented Apr 25, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 25, 2021
@Bouke
Copy link
Contributor Author

Bouke commented Apr 25, 2021

I’d like to keep this issue open.

@stale stale bot removed the wontfix label Apr 25, 2021
@stale
Copy link

stale bot commented Jul 24, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 24, 2021
@Bouke
Copy link
Contributor Author

Bouke commented Jul 25, 2021

I’d like to keep this issue open.

@stale stale bot removed the wontfix label Jul 25, 2021
@stale
Copy link

stale bot commented Dec 20, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants