Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neoforge 1.20.1 "not a valid mod file" #13

Open
Snooziepup opened this issue May 23, 2024 · 19 comments
Open

Neoforge 1.20.1 "not a valid mod file" #13

Snooziepup opened this issue May 23, 2024 · 19 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@Snooziepup
Copy link

on trying to start the game with the mod Neoforge reports that it isn't a valid mod file :(

@Richy-Z
Copy link
Member

Richy-Z commented May 23, 2024

Hello!
I'm sorry to see that the mod is being frustrating on NeoForge 1.20.1. 😔

Would you mind clarifying what you mean by it saying it's "not a valid mod file"? E.g. does a window pop up saying that there's an error with the mod? Does Minecraft just quit unexpectedly? Do you see a long piece of text after Minecraft unexpectedly closed, a crash log?

Being as descriptive as possible will help me help you :)

@Richy-Z Richy-Z self-assigned this May 23, 2024
@Richy-Z Richy-Z added the question Further information is requested label May 23, 2024
@Snooziepup
Copy link
Author

hi, an error screen pops up with the filename of the mod and the message, and a button to proceed to the menu screen but it halts the loading of the rest of the mods so theyre not actually loaded when on the menu

@Richy-Z
Copy link
Member

Richy-Z commented May 23, 2024

Ohhh, I understand it now, the NeoForge mod warning screen.

Are you using the default Minecraft Launcher, MultiMC, Prism Launcher, the Modrinth App, the CurseForge app, etc? (Which launcher?)

@Snooziepup
Copy link
Author

I'm using Prism Launcher.

@ashley-graves
Copy link

same issue here, was planning on adding this to my modpack

@Richy-Z
Copy link
Member

Richy-Z commented Aug 5, 2024

Thanks for sharing! I thought this issue was resolved haha 😅 I'll look into it

@ashley-graves
Copy link

Thanks for sharing! I thought this issue was resolved haha 😅 I'll look into it

here's the error, might help ya out a bit

[05 Aug 2024 15:34:54.214] [main/ERROR] [net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer/SCAN]: Locator {mods folder locator at /home/ashley/.local/share/PrismLauncher/instances/posspack/.minecraft/mods} found an invalid mod file net.minecraftforge.fml.loading.moddiscovery.ModFileInfo@29c5ee1d
net.minecraftforge.fml.loading.moddiscovery.InvalidModFileException: Missing required field mandatory in dependency (threatengl-neoforge-1.3.2-beta.1.jar)
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo$ModVersion.lambda$new$1(ModInfo.java:217) ~[loader-47.2.2.jar:47.2]
        at java.util.Optional.orElseThrow(Optional.java:403) ~[?:?]
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo$ModVersion.<init>(ModInfo.java:217) ~[loader-47.2.2.jar:47.2]
        at net.minecraftforge.fml.loading.moddiscovery.ModInfo.lambda$new$8(ModInfo.java:100) ~[loader-47.2.2.jar:47.2]

@Richy-Z
Copy link
Member

Richy-Z commented Aug 5, 2024

Thank you for sharing your error. A new version of ThreatenGL will be posted in a bit, I've found out that Forge has changed their mods.toml file structure.

@Richy-Z
Copy link
Member

Richy-Z commented Aug 5, 2024

ThreatenGL 1.3.3 will be posted on Modrinth as soon as it finishes building 🤗
Thanks for reporting the issue!

@Richy-Z Richy-Z added the bug Something isn't working label Aug 5, 2024
@Endri2015
Copy link

the warning is still coming in the latest version

@FluffyWolfLord
Copy link

FluffyWolfLord commented Aug 15, 2024

yeah im getting the issue on latest version EDIT:should add more details yes im on prism and neo forge unsure why this happens but after clicking exit to menu is shows every single mod is disabled

@Richy-Z
Copy link
Member

Richy-Z commented Aug 15, 2024

This is still on NeoForge 1.20.1 or 1.20.x?

@Endri2015
Copy link

Endri2015 commented Aug 15, 2024

forge 1.20.1
not neoforge
but it also does not work on neoforge

@LuizLoyola
Copy link

Error still exists:

  • Minecraft 1.20.1
  • Forge 47.3.5
  • threatengl-neoforge-1.3.3-release.1.jar

@LuizLoyola
Copy link

LuizLoyola commented Aug 16, 2024

Just realized I'm using the NeoForge version on Forge. This is the featured version for Forge on Modrinth.
Using the correct version found on the versions page, it works.

image

@Richy-Z
Copy link
Member

Richy-Z commented Aug 16, 2024

@LuizLoyola Modrinth automatically marked the NeoForge upload as Forge haha, sorry that's an error on my part as I didn't notice.

@Richy-Z
Copy link
Member

Richy-Z commented Aug 16, 2024

The mislabelling on Modrinth has been corrected. However the mod still doesn't work on NeoForge either, right?

@natpalmer-e4o4
Copy link

I can confirm that the issue still exists when using the NeoForge version of the mod on 1.20.1 through Prism Launcher

Oddly enough, using the Forge version allows everything to load correctly.

@Richy-Z
Copy link
Member

Richy-Z commented Oct 11, 2024

Thank you all for reporting back on this issue, and sorry for not keeping up with this thread as I took a break to focus on other things.

The reason this entire issue is happening in the first place is because at one point the mod was updated to fix another similar issue related to NeoForge. It looked like NeoForge updated their mod metadata file structure but now it looks like that never happened - its quite unclear at the moment. I'll have to properly research how NeoForge expects this file to look like and I'll get back to you all soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

7 participants