Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DICOM microscopy viewer not working if using PUBLIC_URL #4690

Open
salimkanoun opened this issue Jan 15, 2025 · 1 comment
Open

[Bug] DICOM microscopy viewer not working if using PUBLIC_URL #4690

salimkanoun opened this issue Jan 15, 2025 · 1 comment
Assignees
Labels
Bug Verified Bug reported, reproducible, and verified.

Comments

@salimkanoun
Copy link
Contributor

Describe the Bug

The whole slide imaging viewer is not working when building OHIF with a PUBLIC_URL,
This is due to the request of dicom-microscopy-viewer/dicomMicroscopyViewer.min.js that is missing the PUBLIC_URL prefix

Steps to Reproduce

  1. Build OHIF with a PUBLIC_URL prefix
  2. Try to open a WSI

The current behavior

infinit OHIF loading and network error fetching dicom-microscopy-viewer/dicomMicroscopyViewer.min.js

The expected behavior

Shoud work and network should call {PUBLIC_URL}/dicom-microscopy-viewer/dicomMicroscopyViewer.min.js

OS

Linux

Node version

20

Browser

Chrome latest

@salimkanoun salimkanoun added the Awaiting Reproduction Can we reproduce the reported bug? label Jan 15, 2025
@salimkanoun
Copy link
Contributor Author

i think it comes from here : const imported = await window.browserImportFunction('/dicom-microscopy-viewer/dicomMicroscopyViewer.min.js');
(hardoded root path) in plugin import.js

@sedghi sedghi added Bug Verified Bug reported, reproducible, and verified. and removed Awaiting Reproduction Can we reproduce the reported bug? labels Jan 16, 2025
@linear linear bot assigned sedghi and unassigned wayfarer3130 Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Verified Bug reported, reproducible, and verified.
Projects
None yet
Development

No branches or pull requests

3 participants