Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inconsistent Handling of Patient Name Tag #4703

Conversation

Jaseel-trenser
Copy link
Contributor

@Jaseel-trenser Jaseel-trenser commented Jan 17, 2025

Context

  • The viewer exhibits inconsistent behavior when processing patient name tag provided in a string format. It expects the tag to be formatted as PatientName.Alphabetic.This MR is to supports and processes patient name tags, regardless of whether they are provided in string format or as PatientName.Alphabetic.
  • This PR has been incorporated by FlyWheel.io.
  • Close Issue with Handling Patient Name Tag in String Format #4702

Changes & Results

  • By this change, it supports and processes patient name tags, regardless of whether they are provided in string format or as PatientName.Alphabetic
  • Also done some code optimization by removing duplicate functions formatPN

Testing

Checklist

PR

  • My Pull Request title is descriptive, accurate and follows the
    semantic-release format and guidelines.

Code

  • My code has been well-documented (function documentation, inline comments,
    etc.)

Public Documentation Updates

  • The documentation page has been updated as necessary for any public API
    additions or removals.

Tested Environment

  • OS: Windows
  • Node version: 18
  • Browser: Chrome

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for ohif-platform-docs ready!

Name Link
🔨 Latest commit bb52ebe
🔍 Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/678e6b7335c9350008ae10c9
😎 Deploy Preview https://deploy-preview-4703--ohif-platform-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for ohif-dev ready!

Name Link
🔨 Latest commit bb52ebe
🔍 Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/678e6b73caecf0000814e314
😎 Deploy Preview https://deploy-preview-4703--ohif-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sedghi sedghi requested a review from wayfarer3130 January 20, 2025 14:06
@wayfarer3130
Copy link
Contributor

Thank you - that is a nice cleanup.

@sedghi sedghi merged commit 8aedb2e into OHIF:master Jan 21, 2025
15 of 17 checks passed
dan-rukas pushed a commit to dan-rukas/Viewers that referenced this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Handling Patient Name Tag in String Format
3 participants