Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Can't change HP stage if we change the current active study #4070

Open
salimkanoun opened this issue Apr 28, 2024 · 3 comments · May be fixed by #4707
Open

[Bug] Can't change HP stage if we change the current active study #4070

salimkanoun opened this issue Apr 28, 2024 · 3 comments · May be fixed by #4707
Labels
Awaiting Reproduction Can we reproduce the reported bug?

Comments

@salimkanoun
Copy link
Contributor

Describe the Bug

In a multistage HP, if we change the displayed DICOM Study (for instance loading a pior scan), the HP stages becomes unavailable.

See video :

HPStageChange.mp4

Steps to Reproduce

  1. Go To : https://viewer-dev.ohif.org/tmtv?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.871108593056125491804754960339
  2. Load the "Lung Delays" study in the "Recent" tab of the image series selector
  3. Try to change Stage by hitting ".", a "Hanging Protocol could not be applied" message appear

The current behavior

Can't switch HP stage after changing the DICOM study being displayed

The expected behavior

HP, including stage should work fully as long as the displayset are accepted, no matter if the rendered DICOM study has changed or not

OS

Linux

Node version

20

Browser

Chrome latest
@salimkanoun salimkanoun added the Awaiting Reproduction Can we reproduce the reported bug? label Apr 28, 2024
@sedghi sedghi self-assigned this May 4, 2024
@IbrahimCSAE IbrahimCSAE assigned IbrahimCSAE and sedghi and unassigned sedghi and IbrahimCSAE Jun 21, 2024
@linear linear bot changed the title [Bug] Can't change HP stage if we change the current active study [Bug] Can't change HP stage if we change the current active study Nov 6, 2024
@sedghi sedghi removed their assignment Nov 13, 2024
@salimkanoun
Copy link
Contributor Author

@sedghi I still can reproduce this error following the initial description of the bug

And i found this error message in the console

Error: Error: Error: Reused viewport details ctDisplaySet with ds 21d8ff75-c2b0-a9fe-1d8a-71a51be21713 not valid at fe.setProtocol (HangingProtocolService.ts:893:13) at Object.setHangingProtocol (commandsModule.ts:194:34) at deltaStage (commandsModule.ts:263:26) at Ke.runCommand (CommandsManager.ts:156:14) at HotkeysManager.ts:247:29 at u (mousetrap.js:616:17) at S.t._handleKey (mousetrap.js:677:21) at S.handleKey (mousetrap.js:1008:32) at S.l (recordPlugin.js:58:22) at e.handleKey (recordPlugin.js:212:16)

@sedghi Linear
Copy link
Member

sedghi commented Jan 15, 2025

I can't reproduce this any more on viewer-dev.ohif.org? can you share some videos maybe?

@sedghi sedghi linked a pull request Jan 17, 2025 that will close this issue
Open
@salimkanoun
Copy link
Contributor Author

Yes is still present in viewer-dev.ohif.org but the pull request of Bill in https://deploy-preview-4707--ohif-dev.netlify.app/ is correctly solving it !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Awaiting Reproduction Can we reproduce the reported bug?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Display set should allow remembered updates OHIF/Viewers
3 participants
@sedghi @salimkanoun @IbrahimCSAE