Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] 네비게이션 바 경계선 구현 방식 변경 #306

Closed
1 task done
JinUng41 opened this issue Aug 19, 2024 · 0 comments · Fixed by #307
Closed
1 task done

[refactor] 네비게이션 바 경계선 구현 방식 변경 #306

JinUng41 opened this issue Aug 19, 2024 · 0 comments · Fixed by #307
Assignees
@JinUng41
Labels
💙 JinUng 걸스 토크에 미쳐보고 싶다면 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우)

Comments

@JinUng41
Copy link
Contributor

JinUng41 commented Aug 19, 2024 •
edited
Loading

작업할 브랜치

  • refactor/#306-navigationBar-borderLine 브랜치에서 작업합니다.

✔️ To-Do

  • 네비게이션 바에 사용되는 경계선 구현 방식을 변경
@JinUng41 JinUng41 added ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우) 💙 JinUng 걸스 토크에 미쳐보고 싶다면 labels Aug 19, 2024
@JinUng41 JinUng41 self-assigned this Aug 19, 2024
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
refactor/#306 final키워드 삭제
04808d0 
- extension 영역은 상속에서 재정의가 불가능한 영역이므로 `final` 키워드는 불필요
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
feat/#306 UINavigationController 익스텐션 추가
cc7cb59
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
refactor/#306 BaseViewController 코드 수정
86e99ba
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
chore/#306 주석문 수정
ce953d5
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
refactor/#306 직접 구현한 편의생성자로 변경
bbcdf4c 
- UINavigationController의 익스텐션으로 구현한 편의생성자
@JinUng41 JinUng41 mentioned this issue Aug 19, 2024
Merged
@JinUng41 JinUng41 linked a pull request Aug 19, 2024 that will close this issue
[refactor] 네비게이션 바 경계선 구현 방식 변경 #307
Merged
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
refactor/#306 조건을 활용한 경계선 추가 메서드 호출
82bb0bd
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
Merge branch 'suyeon' into refactor/#306-navigationBar-borderLine
7ed80ca
JinUng41 added a commit that referenced this issue Aug 19, 2024
@JinUng41
Merge pull request #307 from OMZigak/refactor/#306-navigationBar-bord…
a134e58 
…erLine

[refactor] 네비게이션 바 경계선 구현 방식 변경
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JinUng41 JinUng41

Labels
💙 JinUng 걸스 토크에 미쳐보고 싶다면 ♻️ refactor 기존 코드를 리팩토링하거나 수정하는 등 사용 (생산적인 경우)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[refactor] 네비게이션 바 경계선 구현 방식 변경 OMZigak/KKUYOS
1 participant
@JinUng41