Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mystore - B2B v2.0 - compliance check #1590

Open
abhinavv245 opened this issue Jul 16, 2024 · 15 comments
Open

Mystore - B2B v2.0 - compliance check #1590

abhinavv245 opened this issue Jul 16, 2024 · 15 comments

Comments

@abhinavv245
Copy link
Collaborator

All Flows

/on_search

  • FSSAI_LICENSE_NO need not be provided at item level
  • items/parent_item_id is used for variants (categories array), the provided parent_item_id is invalid
  • items/category_id should be the category code for e.g. 'RET10-1012'
  • providers/locations/city code 'std:080' and area code '110047' not matching with 28.475221,77.165261 Lat-Long pair

/on_init

  • order must have required property 'cancellation_terms' (in /confirm and /on_confirm as well)

/on_status

  • Pickup proof (fulfillments/stops/start/instructions/images) is required once the order is picked-up
  • Delivery proof (fulfillments/stops/end/instructions/images) is required once the order is delivered
  • For Non-RFQ flow, the actual invoice needs to be shared and not the PROFORMA_INVOICE

@mystore-in
@mystore-in
Copy link
Contributor

@abhinavv245 what to show pickup proof and delivery proof in case of preprod? Can it be a dummy image?

@abhinavv245
Copy link
Collaborator Author

abhinavv245 commented Jul 17, 2024 via email

@mystore-in
Copy link
Contributor

mystore-in commented Jul 19, 2024 •
edited
Loading

@abhinavv245 We have resubmitted the logs with the fixes. Pull-request

@tanyamadaan
Copy link
Collaborator

Flow1:

on_search:

  1. Define cancellation terms for all fulfillment states. Will it be a 0 cancellation charge when item is out for delivery?
  2. Is rapidor able to consume pincode based serviceability? Kindly start working on polygon based serviceability, would be easier for buyer apps to consume it. - Recommendation
  3. Are you enabling only seller app collecting payment for all the sellers? - However, I see Flow2 has not been submitted.

/on_init:

  1. Define cancellation terms for all fulfillment states. Will it be a 0 cancellation charge when order is out for delivery?
  2. settlement terms should not be specified when BPP is collecting payment.

@mystore-in

@mystore-in
Copy link
Contributor

mystore-in commented Aug 6, 2024 •
edited
Loading

Hi @tanyamadaan

/on_search

  1. currently disabled cancellation after out for delivery
  2. Rapidor is supporting pincode based serviceability
  3. As of now we are not supporting collected by BPP and payment type pre-fulfillment, that's why we have not submitted flow 2. we are giving buyer app pre-fulfillment and seller app on-fulfillment.

/on_init

  1. currently disabled cancellation after out for delivery
  2. we will do that also.

@mystore-in
Copy link
Contributor

@tanyamadaan let me know if there's any other query

@tanyamadaan
Copy link
Collaborator

/on_search

currently disabled cancellation after out for delivery
How are you communicating this? This should be added in cancellation terms.

As of now we are not supporting collected by BPP and payment type pre-fulfillment, that's why we have not submitted flow we are giving buyer app pre-fulfillment and seller app on-fulfillment. -
Your on_search specifies collected by BPP. Kindly correct it in logs.

/on_init

currently disabled cancellation after out for delivery -
How are you communicating this? This should be added in cancellation terms.

settlement terms should not be specified when BPP is collecting payment.
Kindly correct this in Flow1.

@mystore-in

@abhinavv245
Copy link
Collaborator Author

Buyer App

/search

  • context/city code 141 should match the city for the fulfillment end location 302003, 0141

/confirm

  • cancellation terms in confirm are missing

Note: Also submit cancellation flows (Buyer and Seller side cancellation) as per test case scenarios for both Buyer App and Seller App

@mystore-in

@abhinavv245
Copy link
Collaborator Author

Buyer App

/on_search

  • /catalog must NOT have additional properties (bpp/providers) (schema validation by BAP should be done)

/confirm

  • transaction_id attribute is not required in payments/params

Buyer Cancellation

/select

  • why are duplicate fulfillments provided

@mystore-in

@tanyamadaan
Copy link
Collaborator

tanyamadaan commented Aug 29, 2024 •
edited
Loading

Mystore BAP 2.0.2 logs approved.

@mystore-in

@abhinavv245
Copy link
Collaborator Author

Mystore Seller App

/on_search

  • catalog/providers/0/items/1 must have required property 'return_terms'",

/init

  • one extra item is added in /init

/on_init

  • quote/price/value mismatch from /on_select (due to added item in init),
  • Buyer Finder Fee amount mismatches from /search"

/confirm

  • order must have required property 'cancellation_terms'",
  • order/payments/0/@ondc1org1settlement_window must be equal to constant (P2D)",
  • order/payments/0/@ondc1org1withholding_amount must be equal to constant (0.00)",

/on_status

  • fulfillments/0/stops/1/agent must have required property 'person' and 'contact'",
  • on_status call for out-for-delivery is missing

@mystore-in

@mystore-in
Copy link
Contributor

@abhinavv245 This is an incorrect status updated we have only submitted on_search flows

@abhinavv245
Copy link
Collaborator Author

@mystore-in As discussed, reviewing the on_search payloads for new domains as well. Kindly fix the above issues.

@abhinavv245
Copy link
Collaborator Author

RET1A

/on_search

  • Serviceability category must be defined for the same domain code as in context - RET1A",
  • Mandatory tag field [vehicle_make] missing for Automotives, Components & Accessories item[0]",
  • Mandatory tag field [vehicle_model] missing for Automotives, Components & Accessories item[0]",
  • "Mandatory tag field [vehicle_model_year] missing for Automotives, Components & Accessories item[0]",
  • "Mandatory tag field [parts_origin] missing for Automotives, Components & Accessories item[0]",
  • Mandatory tag field [new_arrivals] missing for Automotives, Components & Accessories item[0]"

RET15

/on_search

  • Serviceability category must be defined for the same domain code as in context - RET15",
  • attribute tag codes for productions dimensions - dimension_height, dimension_breadth, , dimension_length to be used
  • colour_name is not a valid attribute
  • colour should have the colour name (#code is currently not sent in b2b)

RET12

/on_search

  • Serviceability category must be defined for the same domain code as in context - RET12",
  • material, manufacture_name_and_address, care_instructions tag fields missing in tags/attribute

@mystore-in

@abhinavv245
Copy link
Collaborator Author

Logs approved for B2B Seller app for RET1A, RET15 and RET12.
@mystore-in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tanyamadaan @mystore-in @abhinavv245