Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8quad - B2B v2.0 - compliance check #1617

Open
abhinavv245 opened this issue Aug 1, 2024 · 8 comments
Open

8quad - B2B v2.0 - compliance check #1617

abhinavv245 opened this issue Aug 1, 2024 · 8 comments

Comments

@abhinavv245
Copy link
Collaborator

All Flows

/on_search

  • providers/0/items must NOT have additional properties (committed_quantity)
  • providers/0/items/0/tags/2/list/value must be string" (pack_size) (Flow 3)
  • items/time/ start and end (validity) should not be past dated

/on_init

  • message/order must have required property 'cancellation_terms' (confirm and on_confirm as well)

Flow 5

/on_select (rejected)

  • Fulfillments/state should be 'Non-serviceable

@8QuadTech

@abhinavv245
Copy link
Collaborator Author

Flow 5

/on_search

  • Attribute tag fields are missing for BPC item (mandatory attributes should be provided as per the taxonomy)

/on_select (reject)

  • fulfillments/0/state/descriptor/code must be equal to one of the allowed values (Serviceable,Non-serviceable)

Cancellation flows

/on_cancel

  • why is payments/params updated to zero and transaction id is removed? (As payment was already made before to BAP)

@8QuadTech

@abhinavv245
Copy link
Collaborator Author

Buyer App

/select

  • why is GST number changed in select call for the same transaction id?

Flow 3

  • search/on_search is future dated to the flow (select onwards)

@8QuadTech

@8QuadTech
Copy link
Contributor

Hi @abhinavv245,

We will be caching catalog on a daily basis and use that. Hence, we will be using our GST number when firing search request and from select onwards, the GST number used will be that of the user's. The transaction id will be different for the search request and select onward requests.

Let me know if all flows need to be redone or only flow-3 needs to be redone

@tanyamadaan
Copy link
Collaborator

/search:

Combination of item and category search is being used. Kindly clarify the use case here.

@8QuadTech

@8QuadTech
Copy link
Contributor

Hi @tanyamadaan ,

There's no specific use case for us here as we are caching. But it may be useful for someone doing live search with category filters on.

Let me know if search.json needs to be rectified.

@tanyamadaan
Copy link
Collaborator

For caching use case - item object is not required. For live search - category is optional.

@8QuadTech
Copy link
Contributor

@tanyamadaan Noted. Will follow the same.

Let me know if there are any other issue or the logs are fine.

@8QuadTech
Copy link
Contributor

@tanyamadaan Also, Rapidor does not support full refresh catalog search as of today. Hence, I had to cache live search to make the logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants