Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxtera - B2B - IGM (BA & SA) - compliance check #1850

Open
amitsinha07 opened this issue Dec 18, 2024 · 10 comments
Open

Proxtera - B2B - IGM (BA & SA) - compliance check #1850

amitsinha07 opened this issue Dec 18, 2024 · 10 comments

Comments

@amitsinha07
Copy link

amitsinha07 commented Dec 18, 2024

@srijit-prox

Seller

Fulfillment

Issue

context/ttl: Is not as per the API contract.
created_at and updated_at[1]: Are mismatched in the issue call.
message/issue/expected_resolution_time: Is not as per the API contract.
message/issue/expected_response_time: Is not as per the API contract.
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
message/issue/complainant_info/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.


On_Issue

The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue.


Issue_Close

context/ttl: Is not as per the API contract.
created_at: Is mismatched in the issue call.
message/issue/rating: Must be equal to one of the allowed values (THUMBS-UP, THUMBS-DOWN).
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
Phone Number for /issue_close API: Is not in the valid range.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.

On_Issue_Status

context.action: Should be "On_issue_status".
context/message_id: Should match between /on_issue and /on_issue_status.
message/issue/updated_at: Should be less than or equal to updated_at[1].
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email: Is invalid.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue_status.

Additional Notes

No Issue_Status Call is available.

ITEM

Issue

context/ttl: Is not as per the API contract.
created_at and updated_at[1]: Are mismatched in the issue call.
message/issue/expected_resolution_time: Is not as per the API contract.
message/issue/expected_response_time: Is not as per the API contract.
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
message/issue/complainant_info/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.

On_Issue

context/timestamp: Should be greater than the context/timestamp from the Issue call.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue.

On_Issue_Status

context.action: Should be "On_issue_status".
context/message_id: Should match between /on_issue and /on_issue_status.
message/issue/updated_at: Should be less than or equal to updated_at[1].
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email: Is invalid.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue_status.

Issue_Close

context/ttl: Is not as per the API contract.
created_at: Is mismatched in the issue call.
message/issue/rating: Must be equal to one of the allowed values (THUMBS-UP, THUMBS-DOWN).
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
Phone Number for /issue_close: Is not in the valid range.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.

General Observation

There is no Issue_Status call.

@amitsinha07
Copy link
Author

@srijit-prox

Buyer

Fulfillment

Issue

context/ttl: Is not as per the API contract.
created_at and updated_at[1]: Are mismatched in the issue call.
message/issue/expected_resolution_time: Is not as per the API contract.
message/issue/expected_response_time: Is not as per the API contract.
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
message/issue/complainant_info/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.


On_Issue

The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue.


Issue_Close

context/ttl: Is not as per the API contract.
created_at: Is mismatched in the issue call.
message/issue/rating: Must be equal to one of the allowed values (THUMBS-UP, THUMBS-DOWN).
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
Phone Number for /issue_close API: Is not in the valid range.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.


On_Issue_Status

context.action: Should be "On_issue_status".
context/message_id: Should match between /on_issue and /on_issue_status.
message/issue/updated_at: Should be less than or equal to updated_at[1].
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email: Is invalid.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue_status.
No Issue_Status Call is available.

ITEM

Issue

context/ttl: Is not as per the API contract.
created_at and updated_at[1]: Are mismatched in the issue call.
message/issue/expected_resolution_time: Is not as per the API contract.
message/issue/expected_response_time: Is not as per the API contract.
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
message/issue/complainant_info/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.


On_Issue

context/timestamp: Should be greater than the context/timestamp from the issue call.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue.


On_Issue_Status

context.action: Should be "On_issue_status".
context/message_id: Should match between /on_issue and /on_issue_status.
message/issue/updated_at: Should be less than or equal to updated_at[1].
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email: Is invalid.
The updated_at of message/issue/issue_action/respondent_actions/index[0]/updated_at: Should be the same as or less than message/issue/updated_at in on_issue_status.


Issue_Close

context/ttl: Is not as per the API contract.
created_at: Is mismatched in the issue call.
message/issue/rating: Must be equal to one of the allowed values (THUMBS-UP, THUMBS-DOWN).
message/issue/complainant_info/contact/phone: Must not have more than 11 characters.
Phone Number for /issue_close API: Is not in the valid range.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email: Is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email: Is invalid.


Additional Notes

No Issue_Status Call is available.

@srijit-prox
Copy link
Contributor

@amitsinha07
Can you share the updated API contract document and the test flows?

@RupalSingla
Copy link

There is no new or updated document for IGM 1.0.0 and pls submit the logs once you had tested this with utility @srijit-prox

@srijit-prox
Copy link
Contributor

srijit-prox commented Dec 19, 2024

There is no new or updated document for IGM 1.0.0 and pls submit the logs once you had tested this with utility @srijit-prox

@RupalSingla share the utility.

https://ondc-official.github.io/ONDC-NTS-Specifications/#/Complaint%20lifecycle%20management/post_issue
This is what we have used.

@RupalSingla
Copy link

https://github.com/ONDC-Official/log-validation-utility. this is the link for the utility

@srijit-prox
Copy link
Contributor

@amitsinha07 @RupalSingla we have fixed the issues and created a PR. Please look into it.

@amitsinha07
Copy link
Author

amitsinha07 commented Dec 26, 2024

@srijit-prox

Feedbacks for (Buyer & Seller)

Fullfillment

Issue

  • Message/issue/expected_resolution_time: Is not as per the API contract.
  • Message/issue/expected_response_time: Is not as per the API contract.

On Issue Status

  • message/issue/issue_actions/complainant_actions/0/complainant_action/open: Should not be there as per the API contract.

Item

Issue

  • Message/issue/expected_resolution_time: Is not as per the API contract.
  • Message/issue/expected_response_time: Is not as per the API contract.

On Issue

  • On_issue payload format: Is wrong.

On Issue Status

  • message/issue/issue_actions/complainant_actions/0/complainant_action/open: Should not be there as per the API contract.

@srijit-prox
Copy link
Contributor

srijit-prox commented Jan 2, 2025

what is the correct format for these?

  1. Message/issue/expected_resolution_time: Is not as per the API contract.
  2. Message/issue/expected_response_time: Is not as per the API contract.

@amitsinha07 @RupalSingla

@amitsinha07
Copy link
Author

@srijit-prox

Duration Format Specification

The expected duration should follow the ISO 8601 Duration Format, commonly used for representing time intervals in a structured and standardized way. Examples include PT2H, PT30M, etc.

For reference, please consult the API Contract Documentation.

ISO 8601 Duration Format Examples:

  • Time-Only Durations:
    • PT2H — Represents 2 hours.
    • PT30M — Represents 30 minutes.
    • PT45S — Represents 45 seconds.

@amitsinha07 amitsinha07 changed the title Proxtera - B2B (BA & SA) - compliance check Proxtera - B2B - IGM (BA & SA) - compliance check Jan 20, 2025
@amitsinha07
Copy link
Author

@srijit-prox

Fulfillment

Issue

message/issue/complainant_info/contract/email - is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email - is invalid.

On_issue

context/timestamp should be greater than the context/timestamp of the issue call.

Issue_CLOSE

message/issue/issue_actions/complainant_actions/0/updated_by/contract/email - is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email - is invalid.

On_issue_status (Unsolicited)

message/issue/issue_actions/complainant_actions/1/updated_by/contract/email - is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email - is invalid.

Item

Issue

message/issue/complainant_info/contract/email - is invalid.
message/issue/issue_actions/complainant_actions/0/updated_by/contract/email - is invalid.

On_issue

context/timestamp should be greater than the context/timestamp of the issue call.

Issue_CLOSE

message/issue/issue_actions/complainant_actions/0/updated_by/contract/email - is invalid.
message/issue/issue_actions/complainant_actions/1/updated_by/contract/email - is invalid.

On_issue_status (Unsolicited)

message/issue/issue_actions/complainant_actions/1/updated_by/contract/email - is invalid.
message/issue/resolution_provider/respondent_info/resolution_support/gros/0/contact/email - is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants