Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navankur - BPP (B2B Exports) - compliance check #1903

Open
abhinavv245 opened this issue Jan 20, 2025 · 1 comment
Open

Navankur - BPP (B2B Exports) - compliance check #1903

abhinavv245 opened this issue Jan 20, 2025 · 1 comment

Comments

@abhinavv245
Copy link
Collaborator

/on_search

  • avoid using dummy values
  • in catalog/fulfillments why are duplicate objects provided? Also, are you supporting 'Self-Pickup', if not please remove this.
  • in catalog/payments why are duplicate objects provided? Only provide the payment types supported by BPP
  • providers/id should be unique
  • Reverse Geocoding for location ID 67580ba80f5cad8920d74a81 failed for provider with id 'P9876'. Area Code 223103 not matching with 34.234457,67.567896 Lat-Long pair.",
  • Serviceability category(in provider/tags) must be defined for the same domain code as in context - RET10, for e.g. RET10-1012, use taxonomy for category codes
    • Serviceability type, val, unit to be based on serviceable country for which the search request is received
  • Country of origin (in items/tags) should be in a valid 'ISO 3166-1 alpha-3' format e.g. IND, SGP"
  • providers/tags (gst_credit_invoice) is optional for exports
  • invalid seller_id_code (AS00059), should mention what id is being used for e.g. gst, and ID number should be provided in seller_id_no
  • FSSAI_LICENSE_NO is not required for exports
  • providers/creds are required for exports (appropriate exports license details to be shared in that)
  • variants (providers/categories) are required in case the items have variants, in this case it is not required (can be used for items of fashion domain, etc)
  • items/qantity, unitized/meaure is 1 tonne, why is available/measure 500 tonne? (same issue with maximum and minimum quantity)
  • invalid category_ids code in items, kindly checkout the taxonomies
  • in return terms, use fulfillment_managed_by as 'seller'
  • items/add_ons (remove dummy values from the contract, also, is this sold along with the item?, do not send if you are not providing add_ons with the item)
  • providers/descriptor/additional_desc/url (in case of RFQ, provide chat url for the seller communication channel for the buyer)
  • catalog/providers/2/items/cancellation_terms/cancellation_fee must NOT have more than 1 properties (use either amount or percentage)
  • in price slabs, howcome unit sale price is 9000?
  • offers are incorrectly used, remove offers as they are not currently enabled

/select

  • INCOTERMS in fulfilments/tags are mandatory for exports

/on_select

  • total of quote/breakup items is not equal to the quote/price
  • what payment modes are supported by seller NP?
  • in case of COD (ON-FULFILLMENT) orders, payments/collected_by would be BPP
  • Delivery charges should be provided in quote/breakup when fulfillment is 'Serviceable'

/on_init

  • in payments, what uri is being shared here?
  • payments/@ondc/org/settlement_details will be shared by buyer app as the payment will be collected by seller app for ON-FULFILLMENT orders
  • payments/tags (BPP_Payment) will be sent in case BPP is collecting prepaid payments (with a valid signature)
  • Timestamp difference for on_init exceeds 5 seconds
  • Buyer Finder Fee amount mismatches from /search

/confirm

  • Transaction ID in payments/params cannot be provided when the payment status is 'NOT-PAID'

/on_confirm

  • Timestamp difference for on_confirm exceeds 5 seconds

/on_status

  • live status updates as per fulfilment state changes to be sent via unsolicited on_status calls (should be provided)

Note: Test the application with Rapidor Reference Application and provide logs with them. Also, confirm whether you are implementing RFQ or Non-RFQ flows.
P.S. Kindly run the log verification tool for each flow and fix all the issues identified before resubmitting the logs .(Attach the report along with the logs for each flow)

@iamayushtiwari

@abhinavv245
Copy link
Collaborator Author

FLOW 1

/on_search

  • items/parent_item_id 'V1' is invalid
  • providers/id should be unique (how are multiple providers having the same id?)
  • Serviceability category must be defined for the same domain code as in context - RET10

/select

  • INCOTERMS in fulfilments/tags are mandatory for exports

/on_select

  • message_id should be same as select API
  • total of quote/breakup items is not equal to the quote/price

/on_init

  • payment/uri is required when prepaid payment is collected by BPP
  • payment/tags (BPP_payment) are required when prepaid payment is collected by BPP

/init

  • why is payment type changed from select, on_select

/on_status

  • live status updates as per fulfilment state changes to be sent via unsolicited on_status calls (should be provided)
  • order/documents/label should be 'INVOICE', invoice to be shared once the order has been picked up

Multiple issues identified, also as mentioned previously, Test the application with Rapidor Reference Application and provide logs with them. Also, confirm whether you are implementing RFQ or Non-RFQ flows.
P.S. Kindly run the log verification tool for each flow and fix all the issues identified before resubmitting the logs .(Attach the report along with the logs for each flow)

@Maneesh235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant