Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend terratests to ensure no challenge is disabled in the environment #1132

Closed
commjoen opened this issue Dec 12, 2023 · 5 comments · Fixed by #1410
Closed

Extend terratests to ensure no challenge is disabled in the environment #1132

commjoen opened this issue Dec 12, 2023 · 5 comments · Fixed by #1410
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@commjoen
Copy link
Collaborator

Currently the Terratests only check the cloud challenges, but there are no checks on whether any challenges are disabled in the home page, while all of the challenges should be enabled. Given #1130 it would be good if we can check that all challenges are usable.

@commjoen commjoen added the enhancement New feature or request label Dec 12, 2023
@commjoen commjoen added this to the 1.8.x milestone Dec 12, 2023
@haanhvu
Copy link

haanhvu commented Dec 21, 2023

I'll work on this

@commjoen
Copy link
Collaborator Author

The issue is all yours sir!

@haanhvu
Copy link

haanhvu commented Jan 1, 2024

@commjoen Hi, AFAIU I need to extend:

  • wrongsecrets_aws_test.go
  • wrongsecrets_azure_test.go
  • wrongsecrets_gcp_test.go

to make sure all challenges are enabled in each cloud platform, right?

@commjoen
Copy link
Collaborator Author

commjoen commented Jan 1, 2024

Yes👍

@haanhvu haanhvu removed their assignment Jan 28, 2024
@commjoen commjoen added the help wanted Extra attention is needed label Feb 9, 2024
@commjoen commjoen assigned commjoen and bendehaan and unassigned commjoen Mar 31, 2024
@commjoen
Copy link
Collaborator Author

for now, isntead of cypress: we need to make sure that no challenge is disabled in the cloud env :) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants