Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add terratest for challenge disabled #1410

Merged
merged 10 commits into from
May 22, 2024
Merged

fix: add terratest for challenge disabled #1410

merged 10 commits into from
May 22, 2024

Conversation

bendehaan
Copy link
Collaborator

@bendehaan bendehaan commented May 21, 2024 •
edited by commjoen
Loading

What kind of changes does this PR include?

  • Fixes or refactors
  • A new challenge
  • Additional documentation
  • Something else

Description

Extend terratest to make sure no challenges are disabled in cloud environments.

Relations

Closes #1132
Closes #1411

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@bendehaan bendehaan requested a review from commjoen as a code owner May 21, 2024 11:32
commjoen
commjoen approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@commjoen commjoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for test results!

@commjoen
Copy link
Collaborator

We have a few issues, which are summarized to: the substituion from tpl to jsut the file no longer work in Azure and GCp

@commjoen commjoen self-requested a review May 22, 2024 09:43
@commjoen
Copy link
Collaborator

@bendehaan when you have the time next week or after, can you please have a look at the tpl substituion issue please?

@commjoen
Copy link
Collaborator

I have filed #1411 separately.

@commjoen commjoen merged commit 5e8637d into master May 22, 2024
16 of 17 checks passed
@commjoen commjoen deleted the fix/terratest-challenge-disabled branch May 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen Awaiting requested review from commjoen commjoen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bendehaan @commjoen