You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I would recommend refactoring jaccard.py as follows:
Have the jacard() function take two token sets as arguments and compute their jaccard similarity (overlap percentage). Checking for empty token bags should be done here.
Have the compare() function deal with the tokenization and anything else (e.g. transforming the distance to a similarity).
The text was updated successfully, but these errors were encountered:
The check for null case should be done at the token bag level rather than the string level:
StringCompare/stringcompare/distance/jaccard.py
Line 17 in be58f4c
I would recommend refactoring jaccard.py as follows:
jacard()
function take two token sets as arguments and compute their jaccard similarity (overlap percentage). Checking for empty token bags should be done here.compare()
function deal with the tokenization and anything else (e.g. transforming the distance to a similarity).The text was updated successfully, but these errors were encountered: