Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CropSAR_px UDF and CropSAR UDF APIs are not consistent #102

Open
1 task
JanssenBrm opened this issue Sep 27, 2023 · 0 comments
Open
1 task

CropSAR_px UDF and CropSAR UDF APIs are not consistent #102

JanssenBrm opened this issue Sep 27, 2023 · 0 comments
Labels

Comments

@JanssenBrm
Copy link
Collaborator

JanssenBrm commented Sep 27, 2023

Description

CropSAR and CropSAR_px are both processes available from the list of UDF processes provided by VITO and are often used in the FuseTS framework. With OpenEO it is possible to also get the documentation of each process, and it turns out that, according to the documentation, the APIs for these two processes are not the same, and it would make more sense if the APIs were aligned.
 
By comparing the function fingerprints with

  • connection.describe_process(id="CropSAR", namespace="vito") and
  • connection.describe_process(id="CropSAR_px", namespace="vito")
     
    The interface of the latter process is much more defined and allows the user greater operability with the UDF, while for the former process, the interface is quite limited.

Recommendations

We recommend that the authors of the processes better align the interface to these two very similar processes.

Acceptance criterea

  • The required parameters for both service use a consistent name and description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant