Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Feedback" from code generation #223

Closed
m-mohr opened this issue Aug 20, 2021 · 2 comments
Closed

"Feedback" from code generation #223

m-mohr opened this issue Aug 20, 2021 · 2 comments

Comments

@m-mohr
Copy link
Member

m-mohr commented Aug 20, 2021

While developing the "code generation" feature in the Web Editor, we found some things that may be considered to be implemented:

  • connection.load_collection: Wouldn't it make sense to allow both id and collection_id as parameters? It would pave the way to deprecate the legacy parameter collection_id at some point.
  • If you use datacube.process('reduce_dimension', ...) and pass a function (def xyz: ...) as callback, the function will throw an error as it can't be serialized. That should likely be supported?
  • Similarly, I can't use datacube.process('save_result', data = ...) as it complains that data is not allowed.
  • There's no way to add metadata to user-defined processes, e.g. adding categories. This is important if you want to share/exchange processes and should be added.
@soxofaan
Copy link
Member

soxofaan commented Oct 4, 2021

@m-mohr
Copy link
Member Author

m-mohr commented Oct 5, 2021

I can't reproduce the save_result issue any longer, so it might have been fixed in the meantime. As all other issues have separate issues, I'm closing here.

@m-mohr m-mohr closed this as completed Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants