Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate a builder #11

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Generate a builder #11

merged 1 commit into from
Aug 13, 2021

Conversation

penghuima
Copy link
Member

After executing the command bazel build //builders/ruby26:builder.image, a builder image will be generated
the builder image penghuima/ruby26

@penghuima penghuima linked an issue Aug 13, 2021 that may be closed by this pull request
Develop a builder #10
Closed
tpiperatgod
tpiperatgod requested changes Aug 13, 2021
View reviewed changes
builders/ruby26/builder.toml Outdated Show resolved Hide resolved
builders/ruby26/BUILD.bazel Outdated Show resolved Hide resolved
builders/ruby26/BUILD.bazel Outdated Show resolved Hide resolved
builders/ruby26/BUILD.bazel Outdated Show resolved Hide resolved
builders/ruby26/BUILD.bazel Outdated Show resolved Hide resolved
builders/ruby26/BUILD.bazel Outdated Show resolved Hide resolved
builders/ruby26/builder.toml Outdated Show resolved Hide resolved
builders/ruby26/builder.toml Outdated Show resolved Hide resolved
@tpiperatgod
Copy link
Member

I think we might need entrypoint buildpack?

tpiperatgod
tpiperatgod requested changes Aug 13, 2021
View reviewed changes
builders/ruby26/builder.toml Outdated
Comment on lines 12 to 13
id = "google.config.entrypoint"
uri = "entrypoint.tgz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the indent

@tpiperatgod tpiperatgod merged commit 217b96f into OpenFunction:main Aug 13, 2021
@tpiperatgod tpiperatgod added the enhancement New feature or request label Aug 13, 2021
@penghuima penghuima linked an issue Aug 14, 2021 that may be closed by this pull request
Modify configuration #12
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpiperatgod tpiperatgod tpiperatgod approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modify configuration Develop a builder
2 participants
@penghuima @tpiperatgod