Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching to disk - PR suggestion #57

Open
oz123 opened this issue Dec 4, 2021 · 0 comments
Open

Caching to disk - PR suggestion #57

oz123 opened this issue Dec 4, 2021 · 0 comments

Comments

@oz123
Copy link

oz123 commented Dec 4, 2021

First, thank you for creating this extension and publishing it. I found it very useful!
The current cache mechanism is only in memory, and it's no so straight how to add on disk caching.
Further, if you try adding a cache mechanism trough conf.py you will bump into pickle errors.
Hence, I forked this extension and created a JSONCache class which saved the commands
and output to disk.
It's useful in cases you do 'make clean' but don't want your commands
to run again for a couple of possible reasons:

  • long execution time - more commands means longer build process
  • expensive execution time, for example: your command create cloud infrastructure ...

My code works, but it still lacks tests. However, if you are interested in it, I will open a PR and
we can discuss what is the best approach to create effective tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant