Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown lists broken #198

Closed
abelards opened this issue Nov 16, 2015 · 8 comments
Closed

Markdown lists broken #198

abelards opened this issue Nov 16, 2015 · 8 comments

Comments

@abelards
Copy link
Contributor

Hi,
when reading many pages [1] I can see the bullet points (or the bold text) are broken.
Did you (or github) update Jekyll or change the markdown interpreter?
In my own blog adding a blank line before the lists does the trick (but adds whitespace you might not want), but then again it may only be an issue of markdown renderer.
I can change whichever pages you want [2] adding these blank lines, if you're OK with this?
Cheers,

[1] e.g. http://www.opentechschool.org/handbooks/city-blueprint.html
[2] like https://github.com/OpenTechSchool/www.opentechschool.org/blob/gh-pages/handbooks/city-blueprint.md

@gnunicorn
Copy link
Member

Hello @abelards,

Yes, it appears there has been a change in the stack that has unnoticed consequences. Thank you for reporting. We'd gladly take you up on the offer: if you want to prepare and send a PR fixing those by adding blank lines (maybe add a screenshot as proof ;) ), that'd be amazing!

Ben

@abelards
Copy link
Contributor Author

I'm not sure about proof, I guess the hidden question was:
how do you generate your jekyll and with which versions/config?

I've seen kramdown in the config and their doc confirms what I've seen[1].
I will definitely send some PRs in my own time, say a page a day or so :)

[1] http://kramdown.gettalong.org/quickref.html#lists

This is a paragraph.
1. This is NOT a list.

1. This is a list!

@gnunicorn
Copy link
Member

Thanks for taking this on!

We only use gh-pages – so, whatever version they have running ;).

In doubt, IMHO it is enough proof to copy-paste the fixed files into a gists and let github render it there properly and take a screenshot of that :) .

@lehmannro
Copy link
Contributor

Let's not put up arbitrary red tape around a "proof" here; I'll gladly merge your PR.

We also have some workshops in Markdown, maybe these should be reviewed as well.

It seems there are no adverse effects to having a blank line before bullet lists. FWIW, the CommonMark spec disagrees with Kramdown on this matter.

@abelards
Copy link
Contributor Author

Not sure if dashboard.html works (tried it, nothing shown).

Also this is pretty weird as SOME of the the Organisers' Schedule bullet points work with no blank line added (just after titles not just after text):
http://www.opentechschool.org/handbooks/workshops/organisers-schedule.html

lehmannro added a commit that referenced this issue Nov 16, 2015
@lehmannro
Copy link
Contributor

dashboard.html requires a query parameter, such as:

http://www.opentechschool.org/dashboard?opentechschool-zurich

(It is, though, slightly broken in the sense that it does not do paging. This leads to Berlin's last workshops falling under the table through all the Colearning.)

Ivoz added a commit that referenced this issue Dec 26, 2015
@Ivoz
Copy link
Member

Ivoz commented Dec 26, 2015

@abelards let me know if above commit solves all problems for this issue? Or is there anything else left to do.

http://www.opentechschool.org/handbooks/city-blueprint.html

@abelards
Copy link
Contributor Author

Yup, that's fixed! Cheers,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants