-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown lists broken #198
Comments
Hello @abelards, Yes, it appears there has been a change in the stack that has unnoticed consequences. Thank you for reporting. We'd gladly take you up on the offer: if you want to prepare and send a PR fixing those by adding blank lines (maybe add a screenshot as proof ;) ), that'd be amazing! Ben |
I'm not sure about proof, I guess the hidden question was: I've seen [1] http://kramdown.gettalong.org/quickref.html#lists
|
Thanks for taking this on! We only use gh-pages – so, whatever version they have running ;). In doubt, IMHO it is enough proof to copy-paste the fixed files into a gists and let github render it there properly and take a screenshot of that :) . |
Let's not put up arbitrary red tape around a "proof" here; I'll gladly merge your PR. We also have some workshops in Markdown, maybe these should be reviewed as well. It seems there are no adverse effects to having a blank line before bullet lists. FWIW, the CommonMark spec disagrees with Kramdown on this matter. |
Not sure if Also this is pretty weird as SOME of the the Organisers' Schedule bullet points work with no blank line added (just after titles not just after text): |
http://www.opentechschool.org/dashboard?opentechschool-zurich (It is, though, slightly broken in the sense that it does not do paging. This leads to Berlin's last workshops falling under the table through all the Colearning.) |
@abelards let me know if above commit solves all problems for this issue? Or is there anything else left to do. |
Yup, that's fixed! Cheers, |
Hi,
when reading many pages [1] I can see the bullet points (or the bold text) are broken.
Did you (or github) update Jekyll or change the markdown interpreter?
In my own blog adding a blank line before the lists does the trick (but adds whitespace you might not want), but then again it may only be an issue of markdown renderer.
I can change whichever pages you want [2] adding these blank lines, if you're OK with this?
Cheers,
[1] e.g. http://www.opentechschool.org/handbooks/city-blueprint.html
[2] like https://github.com/OpenTechSchool/www.opentechschool.org/blob/gh-pages/handbooks/city-blueprint.md
The text was updated successfully, but these errors were encountered: