Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapters without stylesheet #247

Closed
phumberdroz opened this issue Aug 28, 2017 · 7 comments
Closed

Chapters without stylesheet #247

phumberdroz opened this issue Aug 28, 2017 · 7 comments
Labels

Comments

@phumberdroz
Copy link
Member

Hey People,

Our Chapters do not seem to get the css anymore. (404)

@xMartin maybe it has to do with your recent changes ?

Best,

@xMartin xMartin self-assigned this Aug 28, 2017
@xMartin
Copy link
Member

xMartin commented Aug 28, 2017

Thanks @phumberdroz and nice to know you're around :)

I'm looking into it, strange... So looking forward to get rid of this old setup.

@xMartin xMartin removed their assignment Aug 28, 2017
@xMartin
Copy link
Member

xMartin commented Aug 28, 2017

Updated dependencies but that didn't help. No idea :(

Might be connected to this themes stuff we're using that is not really supported any more. Or not.

Anyone else?

@xMartin xMartin added the bug label Aug 28, 2017
@phumberdroz
Copy link
Member Author

As a temporary work around we could remove the variable from https://github.com/OpenTechSchool/www.opentechschool.org/blob/gh-pages/_includes/_head.html#L44 (site.baseurl) and just put the slash in it since i do not think we will serve our website from a different location..

@Ivoz
Copy link
Member

Ivoz commented Aug 29, 2017

It seems we have fallen afoul doing things "the wrong way" along with quite a few other people, judging from the number of +1's. Eventually (github) jekyll updates have turned such usage from 'wrong' into broken.

github/pages-gem#350

I (as far as I remember) had long ago assumed if we were on a domain's subpath, baseurl should be e.g /subpath/ and if on the bare domain then /.

On github's jekyll impl. in recent updates they've decided setting baseurl to / is bad, and if it's set as that, it will be reset to empty. So all path logic breaks and stuff on subpaths like chapter pages breaks.

So there needs to be a commit to add a / after every usage of site.baseurl.

@phumberdroz
Copy link
Member Author

That should work I will prepare a pull request later todaY

@phumberdroz
Copy link
Member Author

8ffa26f fixxed

@xMartin
Copy link
Member

xMartin commented Sep 4, 2017

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants