Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] EFTPOS Hacking Key #27742

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

Drsmail
Copy link
Contributor

@Drsmail Drsmail commented Dec 25, 2024

What Does This PR Do

Adds a new stealth item to a syndicate uplink EFTPOS hacking key. Comes in a box with instruction. When transactions made by a card with a hacked EFTPOS terminal - account details and some aceses are stolen and stored in terminal. To retrive them agent must use an Agent card to copy stolen aceses and print account details.

Algorithm for stealing aceses: If it's a command personal - steal their "job access" + 3 new random aceses from card, else just steal 3 new random aceses from card.

TC COST = 15

P.S. Sorry for some Russian in pictures and code, work in progress

Why It's Good For The Game

My goal with this item was provide an option for antagonist to keep role playing their role i.g. (Bartender, Cook, Hop) and at the same time moving to their goal by acquiring money and access. With introduction of such item i hope more players will choose to play a stealthy, smart agents.

Images of changes

image
image
image
image

Testing

  1. Tested you can buy it from uplink
  2. Tested that you can insert key into hops ESTPOS terminal and remove it.
  3. Tested that yoi can't insert multiple keys
  4. Tested that you can use agent card to copy access / print account details
  5. Tested taht by swapping a normal card, key gets the new accesses

My concern you might run out of space, when printing report with a lot of stolen data.


Declaration

image

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
add: Added EFTPOS Hacking Key in syndicate uplink
/:cl:

@ParadiseSS13-Bot ParadiseSS13-Bot added the -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally label Dec 25, 2024
@SynthTwo
Copy link
Contributor

!wiki_label

@github-actions github-actions bot added the Requires Wiki Update Useful for Wiki Contributers to search for things that need updating label Dec 25, 2024
@Drsmail Drsmail marked this pull request as ready for review December 25, 2024 21:47
@Burzah
Copy link
Member

Burzah commented Dec 26, 2024

I am closing this Pull Request for the time being. As for the our current policy with content related to new antagonist features, it requires pre-approval from the team(s) who will be voting on it. This PR may be re-opened when it obtains the approval from at least one member of each of the voting teams, in this case it will be both balance and design. You can find more information about the policy here. https://github.com/ParadiseSS13/Paradise/blob/master/docs/CODE_OF_CONDUCT.md#types-of-changes-that-need-approval

@Burzah Burzah closed this Dec 26, 2024
@Drsmail
Copy link
Contributor Author

Drsmail commented Dec 26, 2024

I am closing this Pull Request for the time being. As for the our current policy with content related to new antagonist features, it requires pre-approval from the team(s) who will be voting on it. This PR may be re-opened when it obtains the approval from at least one member of each of the voting teams, in this case it will be both balance and design. You can find more information about the policy here. https://github.com/ParadiseSS13/Paradise/blob/master/docs/CODE_OF_CONDUCT.md#types-of-changes-that-need-approval

Thank you for detailed notice! I will reach out to the relevant team members for their input and ensure that the PR meets the necessary requirements. I appreciate the clarification and will review the policy link you shared for better understanding.

@Burzah Burzah reopened this Dec 30, 2024
@Burzah
Copy link
Member

Burzah commented Dec 30, 2024

Reopening as proper pre-approval was given.

@Drsmail
Copy link
Contributor Author

Drsmail commented Dec 30, 2024

@sourcery-ai review

Copy link
Contributor

@Scribble-Sheep Scribble-Sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some grammatical touchups/suggestions based on what sounds right and flows better to me.

I do personally feel that having these messages from a single character kinda makes this item stand out in an odd way vs other syndicate items that usually address you as if the syndicate as a whole, rather than from an individual, but that's besides the point.

code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/modules/economy/economy_machinery/eftpos.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
Co-authored-by: Sheep <[email protected]>
Signed-off-by: Drsmail <[email protected]>
@Drsmail
Copy link
Contributor Author

Drsmail commented Jan 4, 2025

Some grammatical touchups/suggestions based on what sounds right and flows better to me.

I do personally feel that having these messages from a single character kinda makes this item stand out in an odd way vs other syndicate items that usually address you as if the syndicate as a whole, rather than from an individual, but that's besides the point.

Thanks a lot, i am struggling with spelling and grammar. You were really helpful!

@DGamerL DGamerL added Feature This PR is a new addition to the game Balance This PR will modify how effective something is or isnt labels Jan 4, 2025
code/datums/uplink_items/uplink_general.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
code/game/objects/items/devices/eftpos_hack_key.dm Outdated Show resolved Hide resolved
Co-authored-by: CRUNCH <[email protected]>
Signed-off-by: Drsmail <[email protected]>
@Drsmail
Copy link
Contributor Author

Drsmail commented Jan 5, 2025

@Burzah Hello mister head coder, would you be able to help me with labels on this PR? I am not sure if those are important, if it's just a formality, i apologise for the unnecessary ping.

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting approval This PR is waiting for approval internally -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally -Status: Awaiting approval This PR is waiting for approval internally labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Balance This PR will modify how effective something is or isnt Feature This PR is a new addition to the game Requires Wiki Update Useful for Wiki Contributers to search for things that need updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants